fix: clipping rect regression #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing, this works for me ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This fixes the cacluation of the inner region clipping rectangle, which caused this regression.
It also reduces the range of the scrollable lines iterator, which previously did not take border into account. That's not really a problem in practice, since we always need to iterate one more line than the actual grid size anyway, and the clipping rect will take care of clipping it correctly. But it could enable transparency modes when no transparent lines are visible for example.
The
floating_orderfield was removed again, since it's unused and causing clippy warnings.The
sort_orderfield was also unused and removedDid this PR introduce a breaking change?