Migrate dependency from winapi to windows.
#2505
Merged
+360
−719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Briefly complete migrating from `winapi` to `windows`. Known issue: Program will not show a window and closed immediately when building with `profiling` and `gpu_profiling` features enabled. On the other hand, you can still use the program when building without any features enabled. This issue will be fixed in the next commit(s).
|
When this work completed indeed, the issue #2488 can be closed with "completed". |
fredizzimo
requested changes
Apr 27, 2024
fredizzimo
approved these changes
Apr 27, 2024
|
Thank you very much for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly complete migrating from
winapitowindows. Known issue: Program will not show a window and closed immediately when building withprofilingandgpu_profilingfeatures enabled. On the other hand, you can still use the program when building without any features enabled. This issue will be fixed in the next commit(s).What kind of change does this PR introduce?
Did this PR introduce a breaking change?