Solved the pathing issue with a bit less hacking [OSX] #309
+68
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j4qfrost
changed the title
j4qfrost
changed the title
|
I'm going to leave the final merge to you because I'm not sure if you're done with these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopes to resolve #308. This fix is a bit hacky in the sense that it assumes that $HOME/.profile and /etc/profile will exist, which is a safe bet, but doesn't implement a failsafes against those files not existing, and also the OSX specific code might be extracted to a separate function, though it is not strictly necessary.