Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CI SaaS to CircleCI #39

Closed
zchee opened this issue Dec 1, 2018 · 13 comments
Closed

Change CI SaaS to CircleCI #39

zchee opened this issue Dec 1, 2018 · 13 comments
Assignees

Comments

@zchee
Copy link
Member

zchee commented Dec 1, 2018

Now, Travis CI is de-fact SaaS CI. But recently, CircleCI also useful and some improved for the golang testing environment.
I think would be better to switch to CircleCI, because not job pending, faster run testing or etc.

What do you think about it? AFAIK, my company was a switch to CircleCI, As a result, increase build time to x10~x30.
Also, I have much knowledge of CircleCI features.

@zchee
Copy link
Member Author

zchee commented Dec 1, 2018

/cc @garyburd @justinmk

@zchee zchee self-assigned this Dec 1, 2018
@justinmk
Copy link
Member

justinmk commented Dec 1, 2018

Not in favor.

not job pending, faster run testing or etc.
time to x10~x30.

This repo has 43 commits. Those problems are very, very far away from the highest-leverage tasks that could be worked on here.

Neovim project has ~10 repos. If every repo uses a different CI, that increases friction for little benefit.

@justinmk
Copy link
Member

justinmk commented Dec 1, 2018

A high-leverage task, for example, would be: #29 .
It's high-leverage because the benefit:cost ratio is very high.

The benefit:cost ratio of switching CI is very low.

@zchee
Copy link
Member Author

zchee commented Dec 1, 2018

@justinmk Ah, actually, I don't like TravisCI pending time. CircleCI is almost haven't pending time. That's why I suggest CircleCI.
For example(Currently, it's failed...), but CircleCI can following tasks.
https://circleci.com/workflow-run/3f29a06e-0b01-45c6-aadf-a632a424559a

But, Neovim org using TravisCI is org spec? If so, I respect it. Feel free to close this issue.

@justinmk
Copy link
Member

justinmk commented Dec 1, 2018

It's not an org spec. But there should be a good reason to change things. Changing CI has a cost. Is the cost worth the benefit? Is it the highest-leverage task that could be worked on?

@zchee
Copy link
Member Author

zchee commented Dec 1, 2018

@justinmk

It's not an org spec. But there should be a good reason to change things. Changing CI has a cost. Is the cost worth the benefit? Is it the highest-leverage task that could be worked on?

Hm, OK. You're correct.
So, I try to CircleCI setup to my forked https://github.com/zchee/neovim-go-client repository. If you like it, accept it. What this plan?

@justinmk
Copy link
Member

@zchee What do you think about https://sourcehut.org/ ? We are considering this for Nvim core repo as well.

@justinmk
Copy link
Member

GitHub actions probably makes the most sense for this repo, rather than a third party.

neovim/neovim-ruby#62

@zchee
Copy link
Member Author

zchee commented May 10, 2020

@justinmk make sense. I'll send PR which use the GitHub action.

@zchee
Copy link
Member Author

zchee commented May 10, 2020

@justinmk but I didn't repo owner, so can't set secrer env. any idea?

@justinmk
Copy link
Member

justinmk commented May 11, 2020

you are on the "golang" team, and all members in that team have "Admin" role on
this repo. There is no "repo owner" role...

can you access this page: https://github.com/neovim/go-client/settings

Else contact me and I can create the secret at
https://github.com/neovim/go-client/settings/secrets or anything else that needs
to be done.

@zchee
Copy link
Member Author

zchee commented May 12, 2020

@justinmk Ah! I'd mistaken. I can see that URL.
Thanks :D

@zchee
Copy link
Member Author

zchee commented Dec 4, 2020

We switched to GitHub Actions. close.

@zchee zchee closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants