Skip to content

Commit

Permalink
Backup update
Browse files Browse the repository at this point in the history
  • Loading branch information
marvim committed Oct 29, 2023
1 parent 92e47e1 commit d5b5956
Show file tree
Hide file tree
Showing 46 changed files with 9,266 additions and 484 deletions.
2 changes: 1 addition & 1 deletion last_update
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2023-10-27T23:33:26Z
2023-10-29T01:50:11Z
383 changes: 383 additions & 0 deletions repositories/libtermkey/pulls/2.json

Large diffs are not rendered by default.

471 changes: 471 additions & 0 deletions repositories/libvterm/pulls/8.json

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions repositories/neovim/issues/12980.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
{
"color": "c5def5",
"default": false,
"description": "Nvim built-in `:terminal`",
"description": "built-in :terminal or :shell",
"id": 212696822,
"name": "terminal",
"node_id": "MDU6TGFiZWwyMTI2OTY4MjI=",
Expand Down Expand Up @@ -54,8 +54,8 @@
"state": "open",
"state_reason": null,
"timeline_url": "https://api.github.com/repos/neovim/neovim/issues/12980/timeline",
"title": "Fixed-width terminal regardless of window size",
"updated_at": "2023-07-28T06:22:52Z",
"title": "Fixed-width terminal independent of window size",
"updated_at": "2023-10-29T00:09:45Z",
"url": "https://api.github.com/repos/neovim/neovim/issues/12980",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/1270688?v=4",
Expand Down
952 changes: 952 additions & 0 deletions repositories/neovim/issues/13312.json

Large diffs are not rendered by default.

593 changes: 593 additions & 0 deletions repositories/neovim/issues/19156.json

Large diffs are not rendered by default.

54 changes: 49 additions & 5 deletions repositories/neovim/issues/21645.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"assignees": [],
"author_association": "NONE",
"body": "### Neovim version (nvim -v)\r\n\r\nNVIM v0.9.0-dev-1826+g89232b8b4-dirty\r\n\r\n### Vim (not Nvim) behaves the same?\r\n\r\nvim doesn't have cmdheight option\r\n\r\n### Operating system/version\r\n\r\nmacOS 13.1\r\n\r\n### Terminal name/version\r\n\r\nwezterm 20221122-154621-68c754b1\r\n\r\n### $TERM environment variable\r\n\r\nxterm-256color\r\n\r\n### Installation\r\n\r\nhomebrew\r\n\r\n### How to reproduce the issue\r\n\r\nnvim --clean\r\n:set cmdheight=0\r\n:Lexplore\r\n\r\n### Expected behavior\r\n\r\n`:Lexplore` should run immediately when user type `<CR>` in cmdline.\r\n\r\n### Actual behavior\r\n\r\n`:Lexplore` prints empty line before executed.\r\n\r\nEdit: forgot adding one reproduce step.",
"closed_at": null,
"closed_at": "2023-10-28T07:33:30Z",
"comment_data": [
{
"author_association": "CONTRIBUTOR",
Expand Down Expand Up @@ -49,9 +49,53 @@
"type": "User",
"url": "https://api.github.com/users/nwounkn"
}
},
{
"author_association": "CONTRIBUTOR",
"body": "fixed 9455f6b17c6d1009af5d37d62884fe3042abdfa0",
"created_at": "2023-10-28T06:52:49Z",
"html_url": "https://github.com/neovim/neovim/issues/21645#issuecomment-1783725680",
"id": 1783725680,
"issue_url": "https://api.github.com/repos/neovim/neovim/issues/21645",
"node_id": "IC_kwDOAPphoM5qUX5w",
"performed_via_github_app": null,
"reactions": {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/neovim/neovim/issues/comments/1783725680/reactions"
},
"updated_at": "2023-10-28T06:52:49Z",
"url": "https://api.github.com/repos/neovim/neovim/issues/comments/1783725680",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/105592020?v=4",
"events_url": "https://api.github.com/users/nwounkn/events{/privacy}",
"followers_url": "https://api.github.com/users/nwounkn/followers",
"following_url": "https://api.github.com/users/nwounkn/following{/other_user}",
"gists_url": "https://api.github.com/users/nwounkn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nwounkn",
"id": 105592020,
"login": "nwounkn",
"node_id": "U_kgDOBks01A",
"organizations_url": "https://api.github.com/users/nwounkn/orgs",
"received_events_url": "https://api.github.com/users/nwounkn/received_events",
"repos_url": "https://api.github.com/users/nwounkn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nwounkn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nwounkn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nwounkn"
}
}
],
"comments": 1,
"comments": 2,
"comments_url": "https://api.github.com/repos/neovim/neovim/issues/21645/comments",
"created_at": "2023-01-04T16:43:17Z",
"events_url": "https://api.github.com/repos/neovim/neovim/issues/21645/events",
Expand Down Expand Up @@ -87,11 +131,11 @@
"url": "https://api.github.com/repos/neovim/neovim/issues/21645/reactions"
},
"repository_url": "https://api.github.com/repos/neovim/neovim",
"state": "open",
"state_reason": null,
"state": "closed",
"state_reason": "completed",
"timeline_url": "https://api.github.com/repos/neovim/neovim/issues/21645/timeline",
"title": "Strange empty print when `cmdheight=0`",
"updated_at": "2023-10-19T05:16:06Z",
"updated_at": "2023-10-28T07:33:30Z",
"url": "https://api.github.com/repos/neovim/neovim/issues/21645",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/60088301?v=4",
Expand Down
60 changes: 52 additions & 8 deletions repositories/neovim/issues/24799.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"assignees": [],
"author_association": "NONE",
"body": "### Problem\n\nCurrently, `vim.lsp.buf.workspace_symbol()` only searches for workspace symbols from [LSP clients attaching to the current buffer](https://github.com/neovim/neovim/blob/b263c73b083e43761386d46d62524ea104d7abbd/runtime/lua/vim/lsp/buf.lua#L9-L10).\r\n\r\nThis means:\r\n- The user has to open some buffers to search for workspace symbols.\r\n- And only be able to search the workspace symbols from the LSP clients attaching to the current buffer.\r\n\n\n### Expected behavior\n\nSupport the functionality to \r\n- Search the workspace symbols across multiple languages.\r\n- Able to search workspace symbols without opening any buffer.\r\n\r\nLike what VSCode can do:\r\n![](https://preview.redd.it/6awfybsnjzib1.png?width=3840&format=png&auto=webp&s=be6e7b6310362333d1ed69498c34114c1b03dcdc)",
"closed_at": null,
"closed_at": "2023-10-28T18:57:21Z",
"comment_data": [
{
"author_association": "NONE",
Expand Down Expand Up @@ -203,7 +203,7 @@
"total_count": 0,
"url": "https://api.github.com/repos/neovim/neovim/issues/comments/1722168729/reactions"
},
"updated_at": "2023-09-16T07:53:22Z",
"updated_at": "2023-10-28T18:56:29Z",
"url": "https://api.github.com/repos/neovim/neovim/issues/comments/1722168729",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/45122720?v=4",
Expand Down Expand Up @@ -236,15 +236,15 @@
"node_id": "IC_kwDOAPphoM5mpjZ5",
"performed_via_github_app": null,
"reactions": {
"+1": 0,
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"total_count": 1,
"url": "https://api.github.com/repos/neovim/neovim/issues/comments/1722168953/reactions"
},
"updated_at": "2023-09-16T07:54:35Z",
Expand All @@ -269,9 +269,53 @@
"type": "User",
"url": "https://api.github.com/users/BilderLoong"
}
},
{
"author_association": "MEMBER",
"body": "> I realize that It seems that I could start some LSP clients without attaching them to any buffer and then request them one by one like below:\r\n> \r\n> ```\r\n> for _, client in ipairs(lsp.get_clients()) do \r\n> local request_success, request_id = client.request(method, params, handler, bufnr)\r\n> ```\r\n\r\n👍 \r\n",
"created_at": "2023-10-28T18:57:21Z",
"html_url": "https://github.com/neovim/neovim/issues/24799#issuecomment-1783897727",
"id": 1783897727,
"issue_url": "https://api.github.com/repos/neovim/neovim/issues/24799",
"node_id": "IC_kwDOAPphoM5qVB5_",
"performed_via_github_app": null,
"reactions": {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/neovim/neovim/issues/comments/1783897727/reactions"
},
"updated_at": "2023-10-28T18:57:21Z",
"url": "https://api.github.com/repos/neovim/neovim/issues/comments/1783897727",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4",
"events_url": "https://api.github.com/users/justinmk/events{/privacy}",
"followers_url": "https://api.github.com/users/justinmk/followers",
"following_url": "https://api.github.com/users/justinmk/following{/other_user}",
"gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/justinmk",
"id": 1359421,
"login": "justinmk",
"node_id": "MDQ6VXNlcjEzNTk0MjE=",
"organizations_url": "https://api.github.com/users/justinmk/orgs",
"received_events_url": "https://api.github.com/users/justinmk/received_events",
"repos_url": "https://api.github.com/users/justinmk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/justinmk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/justinmk"
}
}
],
"comments": 6,
"comments": 7,
"comments_url": "https://api.github.com/repos/neovim/neovim/issues/24799/comments",
"created_at": "2023-08-20T04:19:10Z",
"events_url": "https://api.github.com/repos/neovim/neovim/issues/24799/events",
Expand Down Expand Up @@ -316,11 +360,11 @@
"url": "https://api.github.com/repos/neovim/neovim/issues/24799/reactions"
},
"repository_url": "https://api.github.com/repos/neovim/neovim",
"state": "open",
"state_reason": null,
"state": "closed",
"state_reason": "completed",
"timeline_url": "https://api.github.com/repos/neovim/neovim/issues/24799/timeline",
"title": "LSP: search workspace symbols across multiple languages without opening any buffer",
"updated_at": "2023-09-18T15:42:24Z",
"updated_at": "2023-10-28T18:57:21Z",
"url": "https://api.github.com/repos/neovim/neovim/issues/24799",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/45122720?v=4",
Expand Down
73 changes: 68 additions & 5 deletions repositories/neovim/issues/25714.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,53 @@
"author_association": "MEMBER",
"body": "### Problem\r\n\r\nThe language server protocol specifies that completion items can contain:\r\n\r\n- snippets\r\n- `additionalTextEdits` (e.g used to add import statements when selecting a completion candidate)\r\n- A `command` (used to execute client side or server side commands - for all sorts of things). For example, vscode defines a `editor.action.triggerParameterHints` client command to trigger a signature help immediately after a completion candidate got selected.\r\n\r\nCurrently neovim core handles none of that, and instead delegates to completion plugins like nvim-cmp, nvim-lsp-compl or others.\r\n\r\n\r\n\r\n### Expected behavior\r\n\r\nHave this functionality built-in.\r\n\r\nWith https://github.com/neovim/neovim/pull/25301 the groundwork for snippet expansion is done.\r\nThe next step is to integrate it with the completion, omnifunc. For that we'll need to setup a `CompleteDone` autocmd similar to:\r\n\r\nhttps://github.com/mfussenegger/nvim-lsp-compl/blob/1642f1c57a83a0b630fdf7f339f4a5550a766407/lua/lsp_compl.lua#L565-L668\r\n\r\n\r\nOpen Questions:\r\n\r\n- [ ] Opt-in or opt-out. Enabling it by default could conflict with above established completion plugins. On the other hand, opt-in is another hurdle in getting started from scratch\r\n- [ ] Snippet expansion trigger - implicit/explicit? (For me, always implicit expanding would make this unusable)\r\n\r\n\r\nProposal:\r\n\r\n- Make it opt-in via a `vim.lsp.completion.attach(client, bufnr, [opts])` method that can be called in a `LspAttach` autocmd. It would sets up a `CompleteDone` autocmd for the given buffer and client.\r\n- Add a `vim.lsp.completion.accept()` function that if called causes the next accempted completion candidate to expand a snippet, if the completion item contains one. To be used in a mapping like:\r\n\r\n```\r\nvim.keymap.set('i', '<CR>', function()\r\n return vim.lsp.completion.accept() and '<c-y>' or '<CR>'\r\nend, { expr = true })\r\n```\r\n\r\n`opts` relate a bit to the auto-completion aspect and https://github.com/neovim/neovim/issues/25670, and might not be necessary in a first step.\r\n",
"closed_at": null,
"comment_data": [],
"comments": 0,
"comment_data": [
{
"author_association": "MEMBER",
"body": "> Currently neovim core handles none of that, and instead delegates to completion plugins like nvim-cmp, nvim-lsp-compl or others.\r\n\r\nCan we extend the builtin completion concepts rather than add a LSP-specific interface?\r\n\r\n> `vim.lsp.completion.attach(client, bufnr, [opts])`\r\n\r\n\"Attach to completion\" feels like we are overextending the concept of attach. (And \"attach\" in general is probably a signal that we're missing something in the [events interface](https://github.com/neovim/neovim/issues/19156).)\r\n\r\nWould it make sense to \"attach to client\"? Since LSP clients are the main primitive in LSP, like how buffer/win/tab are the primitives in Nvim.",
"created_at": "2023-10-28T18:50:01Z",
"html_url": "https://github.com/neovim/neovim/issues/25714#issuecomment-1783896243",
"id": 1783896243,
"issue_url": "https://api.github.com/repos/neovim/neovim/issues/25714",
"node_id": "IC_kwDOAPphoM5qVBiz",
"performed_via_github_app": null,
"reactions": {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/neovim/neovim/issues/comments/1783896243/reactions"
},
"updated_at": "2023-10-28T18:50:01Z",
"url": "https://api.github.com/repos/neovim/neovim/issues/comments/1783896243",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4",
"events_url": "https://api.github.com/users/justinmk/events{/privacy}",
"followers_url": "https://api.github.com/users/justinmk/followers",
"following_url": "https://api.github.com/users/justinmk/following{/other_user}",
"gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/justinmk",
"id": 1359421,
"login": "justinmk",
"node_id": "MDQ6VXNlcjEzNTk0MjE=",
"organizations_url": "https://api.github.com/users/justinmk/orgs",
"received_events_url": "https://api.github.com/users/justinmk/received_events",
"repos_url": "https://api.github.com/users/justinmk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/justinmk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/justinmk"
}
}
],
"comments": 1,
"comments_url": "https://api.github.com/repos/neovim/neovim/issues/25714/comments",
"created_at": "2023-10-19T08:56:33Z",
"events_url": "https://api.github.com/repos/neovim/neovim/issues/25714/events",
Expand All @@ -22,6 +67,15 @@
"node_id": "MDU6TGFiZWw3Nzk5NzQ3Ng==",
"url": "https://api.github.com/repos/neovim/neovim/labels/enhancement"
},
{
"color": "FBCA04",
"default": false,
"description": "needs a clear design proposal",
"id": 124510010,
"name": "needs:design",
"node_id": "MDU6TGFiZWwxMjQ1MTAwMTA=",
"url": "https://api.github.com/repos/neovim/neovim/labels/needs:design"
},
{
"color": "c5def5",
"default": false,
Expand All @@ -30,6 +84,15 @@
"name": "lsp",
"node_id": "MDU6TGFiZWw2NjI1NjYzNzA=",
"url": "https://api.github.com/repos/neovim/neovim/labels/lsp"
},
{
"color": "C5DEF5",
"default": false,
"description": "Nvim built-in (omni)completion",
"id": 3214348835,
"name": "completion",
"node_id": "MDU6TGFiZWwzMjE0MzQ4ODM1",
"url": "https://api.github.com/repos/neovim/neovim/labels/completion"
}
],
"labels_url": "https://api.github.com/repos/neovim/neovim/issues/25714/labels{/name}",
Expand All @@ -39,23 +102,23 @@
"number": 25714,
"performed_via_github_app": null,
"reactions": {
"+1": 1,
"+1": 16,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"total_count": 16,
"url": "https://api.github.com/repos/neovim/neovim/issues/25714/reactions"
},
"repository_url": "https://api.github.com/repos/neovim/neovim",
"state": "open",
"state_reason": null,
"timeline_url": "https://api.github.com/repos/neovim/neovim/issues/25714/timeline",
"title": "Add support for LSP completion side effects (snippet expansion, command execution, additionalTextEdits)",
"updated_at": "2023-10-19T13:18:32Z",
"updated_at": "2023-10-28T18:50:17Z",
"url": "https://api.github.com/repos/neovim/neovim/issues/25714",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/38700?v=4",
Expand Down
Loading

0 comments on commit d5b5956

Please sign in to comment.