-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps #350
Update deps #350
Conversation
Problem: Loading unnecessary files for bootstrap. Solution: Update bootstrap version and remove old files. Bootstrap now includes popperjs. Doesn't need jquery anymore. Bootstrap now includes its own reboot. Doesn't need normalize.css anymore.
Problem: Ruby version in nix-shell is too old to build the site. Solution: Update ruby version and nix-shell commands.
Problem: Lato font is no longer being used. Inter font is not being loaded. No difference between serif and sans-serif. Solution: Remove old files. Update variables to load Inter font properly. Use only sans-serif fonts.
Problem: New Bootstrap update broke navbar styling. Solution: Update navbar to match previous styling. Clean up a bit.
This is definitely wanted, but why are there 18k lines added? |
Good question. I think that's mostly the unminified versions of bootstrap.css and bootstrap.bundle.js. I included the unminified versions because it's easier to browse through without having to load up a dev environment. Also the repo currently has the unminified and minified versions so I was just pattern matching. But I dont have any strong feelings about including it. Should I go ahead and remove the unminified files? |
well, if that's the case, can the old ones be removed? |
Sure. Give me like 30 minutes and I'll clean it up. |
Problem: Don't need unminified versions. Solution: Remove unminified versions.
Okay, cleaned it up. The diff is now much more reasonable. Also made pull requests to update the links from the other repos to point to the correct files. |
} | ||
} | ||
|
||
body { | ||
/* font-family: "Helvetica Neue", Helvetica, Calibri, Arial, sans-serif; */ | ||
font-family: var(--serif-fonts); | ||
font-family: var(--sans-serif-fonts); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely weren't using serif, I wonder why this was like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that this matches the file from https://getbootstrap.com/docs/5.3/getting-started/download/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is extremely helpful. Keeping up with details like "normalize.css vs reboot" takes attention. Thank you!
Problem: Not using minified version of bootstrap dep. Using wrong font. See neovim/neovim.github.io#350 Solution: Update link to bootstrap CSS file. Remove refs to old font.
Problem: Not using minified version of bootstrap. Don't need to load normalize with new version of bootstrap. See neovim/neovim.github.io#350 Solution: Update link to bootstrap file. Remove link to normalize.
Problem: Not using minified version of bootstrap. Don't need to load normalize with new version of bootstrap. See neovim/neovim.github.io#350 Solution: Update link to bootstrap file. Remove link to normalize.
Hi. I was browsing the docs and I noticed that maybe I could help clean up some things.
Related issue: #228
Things done in this pull request:
Everything built fine on my machine. The only visual change is using the Inter font.
Also there's some scripts that need to get their references updated to the correct filenames:
on the main site:
https://github.com/neovim/neovim/blob/40ce8577977fcdce8ad76863c70eb522e4cefd4d/scripts/gen_help_html.lua#L829
And the docs:
https://github.com/neovim/doc/blob/6f805e0d6085bd29ef881dcfe907638c943aac75/templates/report-header.sh.html#L11
I can do pull requests to update those if everything looks good, I just wanted to make sure that I didn't miss anything, or do something dumb. This pull request got a little bigger than I expected.