Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This way success/failure return from this function is more precise.
- Loading branch information
This way success/failure return from this function is more precise.
31cdb22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZyX-I
This causes a slowdown in Docker for me (Alpine Linux 3.5).
Any idea why?
Will file an issue for it later anyway.
31cdb22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not know. file_fsync is a thing which will be done in any case, when freeing fp.
31cdb22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZyX-I
So should I test it with just this change reverted then?
31cdb22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think yes, I do not see any reasons for this change to cause any problems, except for obvious missing of error return (errorred file_free which also does file_fsync causes error message, but returned number is still zero), which AFAIR is not even tested.
31cdb22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZyX-I
Followed up in #6420.