Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: use shell-test / other helper instead of cat #10574

Closed
blueyed opened this issue Jul 22, 2019 · 1 comment · Fixed by #10580
Closed

tests: use shell-test / other helper instead of cat #10574

blueyed opened this issue Jul 22, 2019 · 1 comment · Fixed by #10580
Labels
bug issues reporting wrong behavior test

Comments

@blueyed
Copy link
Contributor

blueyed commented Jul 22, 2019

There are a lot of tests being skipped still on Windows due to lack of cat -, or handled with something different (find, via 03e69a5).

This should use a consistent helper/method, e.g. a new mode with shell-test, which would behave like cat then.
@blueyed blueyed added bug issues reporting wrong behavior test labels Jul 22, 2019
blueyed referenced this issue Jul 22, 2019
@janlazo
test: win: use find.exe /v "" as alternative cat -
03e69a5
@blueyed blueyed mentioned this issue Jul 22, 2019
Merged
@justinmk
Copy link
Member

justinmk commented Jul 22, 2019 •
edited

cat.exe is shipped and available on our Windows build. Though it doesn't always seem to work as expected (different buffering?)

Some of the cases currently skipped on Windows might be solved by #10561

blueyed added a commit to blueyed/neovim that referenced this issue Jul 22, 2019
@blueyed
tests: use "cat" also on Windows
2d3af8b 
Fixes neovim#10574.
@blueyed blueyed mentioned this issue Jul 22, 2019
Merged
blueyed added a commit to blueyed/neovim that referenced this issue Jul 25, 2019
@blueyed
tests: use "cat" also on Windows
d31afa1 
Fixes neovim#10574.
blueyed added a commit to blueyed/neovim that referenced this issue Jul 26, 2019
@blueyed
tests: use "cat" also on Windows
2906c70 
Fixes neovim#10574.

Keeps 'can be called recursively' pending for now, see
neovim#10580 (comment).
timeyyy pushed a commit to timeyyy/neovim that referenced this issue Aug 9, 2019
@blueyed @timeyyy
tests: use "cat" also on Windows
67b99a4 
Fixes neovim#10574.

Keeps 'can be called recursively' pending for now, see
neovim#10580 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug issues reporting wrong behavior test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: use "cat" also on Windows blueyed/neovim
2 participants
@blueyed @justinmk