Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line numbers and errors can be hard to read with QuickFixLine highlighting priority. #13400

Open
shade-of-noon opened this issue Nov 27, 2020 · 0 comments
Open

Line numbers and errors can be hard to read with QuickFixLine highlighting priority. #13400

shade-of-noon opened this issue Nov 27, 2020 · 0 comments
Labels
bug issues reporting wrong behavior highlight

Comments

@shade-of-noon
Copy link
Contributor

shade-of-noon commented Nov 27, 2020 •
edited

Steps to reproduce using nvim -u NORC

  1. :set errorformat=%f %l.%t%n
  2. Sample text: 
    Line 1.E9
Line 2.W15
  3. :caddbuffer | copen

Current behaviour

image

Naturally, this is theming dependent, but I think the expected behaviour is for line numbers and the error tag thingy to be easily distinguishable from normal text contained in the active qf line.

Expected behaviour

image
@shade-of-noon shade-of-noon added the bug issues reporting wrong behavior label Nov 27, 2020
@shade-of-noon shade-of-noon changed the title screen.c: Make line numbers and errors override QuickFixLine highlighting. Make line numbers and errors override QuickFixLine highlighting. Nov 27, 2020
shade-of-noon added a commit to shade-of-noon/neovim that referenced this issue Nov 27, 2020
@shade-of-noon
screen.c: Allow QuickFixLine to be overriden.
ffdb75f 
I modified the relevant tests and added an extra one. The tests already
included conditions on CursorLine vs QuickFixLine, so I made sure those
conditions were still satisfied with my changes.

Closes neovim#13400.
@shade-of-noon shade-of-noon mentioned this issue Nov 27, 2020
Closed
@shade-of-noon shade-of-noon changed the title Make line numbers and errors override QuickFixLine highlighting. Line numbers and errors can be hard to read with QuickFixLine highlighting priority. Nov 27, 2020
shade-of-noon added a commit to shade-of-noon/neovim that referenced this issue Nov 29, 2020
@shade-of-noon
screen.c: Allow QuickFixLine to be overriden.
0c17582 
I modified the relevant tests and added an extra one. The tests already
included conditions on CursorLine vs QuickFixLine, so I made sure those
conditions were still satisfied with my changes.

Closes neovim#13400.
shade-of-noon added a commit to shade-of-noon/neovim that referenced this issue Nov 29, 2020
@shade-of-noon
screen.c: Allow QuickFixLine to be overriden.
9304783 
I modified the relevant tests and added an extra one. The tests already
included conditions on CursorLine vs QuickFixLine, so I made sure those
conditions were still satisfied with my changes.

Closes neovim#13400.
shade-of-noon added a commit to shade-of-noon/neovim that referenced this issue Nov 29, 2020
@shade-of-noon
screen.c: Allow QuickFixLine to be overriden.
bf5bb3a 
I modified the relevant tests and added an extra one. The tests already
included conditions on CursorLine vs QuickFixLine, so I made sure those
conditions were still satisfied with my changes.

Closes neovim#13400.
shade-of-noon added a commit to shade-of-noon/neovim that referenced this issue Dec 11, 2020
@shade-of-noon
screen.c: Allow QuickFixLine to be overriden.
69172cb 
I modified the relevant tests and added an extra one. The tests already
included conditions on CursorLine vs QuickFixLine, so I made sure those
conditions were still satisfied with my changes.

Closes neovim#13400.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug issues reporting wrong behavior highlight
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

screen.c: Allow QuickFixLine to be overridden shade-of-noon/neovim
2 participants
@zeertzjq @shade-of-noon