Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multigrid and guis which send mouse inputs to specific windows interact incorrectly with tabline #13416

Closed
Kethku opened this issue Nov 30, 2020 · 3 comments
Labels
bug issues reporting wrong behavior ui ui-extensibility UI extensibility, events, protocol

Comments

@Kethku
Copy link

Kethku commented Nov 30, 2020

  • nvim --version:
NVIM v0.5.0-828-g0a95549d6
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.16.27023/bin/Hostx86/x64/cl.exe /DWIN32 /D_WINDOWS /W3 /MD /Zi /O2 /Ob1 /DNDEBUG /W3 -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -DWIN32 -D_WIN32_WINNT=0x0600 -DINCLUDE_GENERATED_DECLARATIONS -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -IC:/projects/neovim/build/config -IC:/projects/neovim/src -IC:/projects/nvim-deps/usr/include -IC:/projects/neovim/build/src/nvim/auto -IC:/projects/neovim/build/include
Compiled by appveyor@APPVYR-WIN

Features: -acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM\sysinit.vim"
  fall-back for $VIM: "C:/Program Files/nvim/share/nvim"

Run :checkhealth for more info
  • Operating system/version:
    Windows 10

Actual behaviour

Using a Gui with multigrid extension enabled, and which sends mouse inputs per grid rather than to the base grid, clicking in the top row of a given window will instead send the click to the tabline which may select a different buffer.

Clicking here:
image

Results in:
image

Clicking here:
image

Results in:
image

Expected behaviour

Clicking in the top row of a window should send the input to that window rather than the tabline.

@Kethku Kethku added the bug issues reporting wrong behavior label Nov 30, 2020
@Kethku
Copy link
Author

Kethku commented Nov 30, 2020

If I disable the tabline, or enable the tabline gui extension, this issue goes away. I think that the tabline is hard coded to intercept mouse inputs which have a y of 1 (or 0, I don't remember) which is incorrect when the grid which the mouse input is sent to is not the global one.

@zeertzjq
Copy link
Member

Does this bug still exist?

@Kethku
Copy link
Author

Kethku commented Jan 26, 2022

No it is fixed :) Thanks for the ping

@Kethku Kethku closed this as completed Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues reporting wrong behavior ui ui-extensibility UI extensibility, events, protocol
Projects
None yet
Development

No branches or pull requests

3 participants