Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bram needs help understanding redraw on neovim vs vim #14225

Closed
poetaman opened this issue Mar 27, 2021 · 5 comments
Closed

Bram needs help understanding redraw on neovim vs vim #14225

poetaman opened this issue Mar 27, 2021 · 5 comments

Comments

@poetaman
Copy link

Bram needs help in understanding difference between :redraw/ :redraw! in neovim vs vim. neovim seems do be doing something that makes openGL based GPU-accelerated terminal emulators not stutter/flicker on redraws. Here's his call for help: vim/vim#8002 (comment)

@klooj
Copy link

klooj commented Mar 29, 2021

this is misleading and not an issue.

image

@poetaman
Copy link
Author

poetaman commented Mar 29, 2021

@klooj What is misleading, and not an issue? To give you some benefit of doubt, if you just read his first sentence then there is no issue. The rest of it suggests he doesn't know why Vim has stutter on redraw, and neovim doesn't. Given he is a one man army of Vim's codebase, he has left it as a question for online community to investigate & answer what's the difference between redraw in both editors. It would be the least effort for neovim core team to answer his question.

Also as a sidenote, this is a "question" issue. Neovim chat forum never responded, questions like these disappear in abyss over there. Its posted here only after trying the recommended channel. Hopefully relevant developers will get an eye on it.

@bfredl
Copy link
Member

bfredl commented Mar 29, 2021

I would be happy to take a closer look into what the difference is. I've just been busy lately, and spent my FOSS time into stuff needed for neovim 0.5 release. But one difference that comes to mind: AFAIK vim only allows you to do a VALID redraw with :redraw or a CLEAR redraw with <c-f> or :redraw! or :mode, while neovim allows you to force a NOT_VALID redraw without forcing a CLEAR using :redraw! (while :mode or <c-f> still does a CLEAR).

@poetaman
Copy link
Author

@bfredl Sure man, take your time. I confirm that :mode stutters screen in neovim. So could be that the behavior of redraw, and mode are similar in Vim. Anyway, I'll wait for your final analysis, on what the exact difference is (so Bram knows if he can improve Vim's redraw behavior).

@mhinz
Copy link
Member

mhinz commented Apr 9, 2021

I'm sure bfredl has a (very, very) long list of things in screen.c he wants to change, so he doesn't need this issue to stay reminded about it.

If this is about changes in Vim, it should be discussed in a Vim issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants