Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGL terminals: At times visualizer flickers #501

Open
poetaman opened this issue Aug 29, 2021 · 1 comment
Open

OpenGL terminals: At times visualizer flickers #501

poetaman opened this issue Aug 29, 2021 · 1 comment
Assignees
Labels

Comments

@poetaman
Copy link

poetaman commented Aug 29, 2021

Describe the bug
OpenGL based GPU accelerated terminals like Alacritty, WezTerm, etc update screen differently compared to older terminals. Occasionally while playing music the Visualizer screen seems to flicker. The problem could be similar to Vim's way of redrawing the screen or just that there is some glitch in the pipeline of frames to display. vim/vim#8002. Or check this, the developer fixed their redrawing mechanism: valebes/rsClock#4 (comment):

The problem might not occur at times for entire song, and at times it happens more often... That is unlike rsclock, or vim, though more close to rsclock's behavior in the video at valebes/rsClock#4 (comment)... I think adding a little bit of transparency to the background might also help in observing it.

Modern GPU based terminals draw the entire frame on redraws. The way to avoid screen from stuttering is to use a different approach to redrawing screen.
The solution is mentioned in neovim/neovim#14225 (comment), and vim/vim#8002 (comment). The solution is to redraw with
NOT_VALID, which would redraw everything but not clear the screen.

To Reproduce
Steps to reproduce the behavior:
Open the default visualizer in an openGL terminal like Alacritty or WezTerm (IMO the problem is more often visible in WezTerm, but can't say for sure).

Expected behavior
At least not flicker the screen.

Screenshots/Logs
If applicable, add screenshots or logs to help explain your problem.

Desktop (please complete the following information):

  • macOS 11.5.2 Darwin ARM
  • Alacritty/WezTerm, zsh
  • ncmpcpp --version: ncmpcpp 0.9.2
@poetaman
Copy link
Author

One of the reason screens flicker is that they are cleared instead of drawn again... not sure if that is what could be going on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants