Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libuv changing place. #1560

Closed
elmart opened this issue Nov 26, 2014 · 4 comments
Closed

Libuv changing place. #1560

elmart opened this issue Nov 26, 2014 · 4 comments
Labels
needs:discussion For PRs that propose significant changes to some part of the architecture or API

Comments

@elmart
Copy link
Contributor

elmart commented Nov 26, 2014

I just picked this from HNs:
joyent/libuv#1573 (comment)

It seems they will take it as a opportunity to cleanup pending issues/PR's, too. Do we have anything pending to that respect?
@happy-dude
Copy link
Sponsor Contributor

Thankfully, doing a quick grep and searching on the Github repo for references to joyent reveal that the following files refer to github.com/joyent/libuv:

Of those files, only CMakeLists.txt has code that seems vital to Neovim's build process.

@aktau
Copy link
Contributor

aktau commented Nov 26, 2014

Well, an interested dev can make up a quick PR changing the references to future proof us whenever they feel like then :).

@happy-dude happy-dude mentioned this issue Nov 26, 2014
Merged
@happy-dude
Copy link
Sponsor Contributor

Just made my first pull request to the project!

Any feedback would be absolutely lovely.

happy-dude added a commit to happy-dude/neovim that referenced this issue Nov 27, 2014
@happy-dude
Change refs for joyent/libuv repo to libuv/libuv
08e5db6 
* References to old repository found through grepping
* Replace references from github.com/joyent/libuv to github.com/libuv/libuv
* Fix previous commit by not including whitespace changes

For issue neovim#1560.
happy-dude added a commit to happy-dude/neovim that referenced this issue Nov 27, 2014
@happy-dude
Change refs for joyent/libuv repo to libuv/libuv
a4ad5f6 
* References to old repository found through grepping
* Replace references from github.com/joyent/libuv to github.com/libuv/libuv
* Fix previous commit by not including whitespace changes

 For issue neovim#1560.
@ghost
Copy link

ghost commented Dec 3, 2014

I believe this can be closed.

@elmart elmart closed this as completed Dec 3, 2014
@clason clason added needs:discussion For PRs that propose significant changes to some part of the architecture or API and removed discuss labels Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs:discussion For PRs that propose significant changes to some part of the architecture or API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@elmart @aktau @happy-dude @justinmk @clason