undefined ref to luv_set_thread/cthread at link

[mckellygit]

Neovim version (nvim -v)

0.7.0 (latest main) commit a7bc3e0

Vim (not Nvim) behaves the same?

n/a

Operating system/version

ubuntu 20.04

Terminal name/version

n/a

$TERM environment variable

n/a

Installation

git source, latest main

How to reproduce the issue

cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo ..
make

Expected behavior

compiles and links successfully

Actual behavior

/usr/bin/ld: /tmp/nvim.GsCqjb.ltrans24.ltrans.o: in function nlua_common_vim_init': /home/user/Downloads/neovim/src/nvim/lua/executor.c:503: undefined reference to luv_set_thread'
/usr/bin/ld: /home/user/Downloads/neovim/src/nvim/lua/executor.c:504: undefined reference to `luv_set_cthread'

[mckellygit]

Trying to go backwards and find a recent commit that does link ok.

[mckellygit]

commit d0f8f76 is ok.
commit b87867e has issue. Not sure if I am supposed to add options to cmake now or install some addl pkg, checking.

[clason]

You need to a) make sure that you have libluv 1.43.0 installed and b) regenerate the cmake files (make distclean before make).

[mckellygit]

ok, thanks.
I do wipe clean the build dir and a fresh cmake from zero.

[mckellygit]

I dont think I have a separate libluv installed. I can go get that. But doesn't nvim use an included one ?
commit 2438696
Merge: 9d3370a 97ed3ef
Author: James McCoy jamessan@jamessan.com
Date: Sun Feb 27 09:16:50 2022 -0500

Merge pull request #17540 from jamessan/luv-bump-fix

ci(lint): use bundled luv until system packages are updated

[clason]

Yes, if you just make from the repo, you'll use the bundled one. I'm having to guess here what may be wrong with your setup.

[mckellygit]

ok, I found my error, thank you.
I was always cleaning out the build dir and starting a cmake from zero, but without the parent dir distclean the .deps dir was old and did not have the latest luv.
ty again,
-m