Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LuaJIT: update to git v2.1 branch #36790

Closed
wants to merge 1 commit into from

Conversation

CameronNemo
Copy link
Contributor

CC: @q66

The LuaJIT maintainer has not published a new version in 5 years, but he
has steadily added commits to the "2.1" branch, linked below.

https://repo.or.cz/luajit-2.0.git/shortlog/refs/heads/v2.1

Projects like neovim build against this branch or master due to the lack
of a recent release.
Furthermore, distributions such as Arch Linux and Debian Sid are
building from a commit rather than a release.

archlinux/svntogit-community@11473c3

https://salsa.debian.org/lua-team/luajit/-/commit/e06cbc6d2a61b253056214f5ed3f03ce661e31f9

The LuaJIT upstream maintainer has declined to cut a release, reasoning
"Releases are an antiquated concept".

LuaJIT/LuaJIT#665 (comment)

Testing the changes

  • I tested the changes in this PR: YES, on x86_64 and aarch64

The LuaJIT maintainer has not published a new version in 5 years, but he
has steadily added commits to the "2.1" branch, linked below.

https://repo.or.cz/luajit-2.0.git/shortlog/refs/heads/v2.1

Projects like neovim build against this branch or master due to the lack
of a recent release.
Furthermore, distributions such as Arch Linux and Debian Sid are
building from a commit rather than a release.

archlinux/svntogit-community@11473c3

https://salsa.debian.org/lua-team/luajit/-/commit/e06cbc6d2a61b253056214f5ed3f03ce661e31f9

The LuaJIT upstream maintainer has declined to cut a release, reasoning
"Releases are an antiquated concept".

LuaJIT/LuaJIT#665 (comment)
@q66
Copy link
Contributor

q66 commented Apr 21, 2022

i think that packages should be switched from luajit to regular lua where possible

for years luajit has been nothing but a poorly portable liability with a bus factor of 1 (go look at the code and you'll know why), and we should do away with it where we can

neovim can use standard lua, as can a lot of things that are currently built against luajit

@q66
Copy link
Contributor

q66 commented Apr 21, 2022

also I'm like 90% sure the ppc64le patch does not apply anymore as I don't see it updated

@CameronNemo
Copy link
Contributor Author

CameronNemo commented Apr 21, 2022

neovim can use standard lua

Maybe it can, but the devs don't seem to want to support such a setup:

Neovim should not be built against PUC Lua, and certainly not Lua 5.4 (which is incompatible with Lua 5.1, which Neovim targets).

neovim/neovim#18169

also I'm like 90% sure the ppc64le patch does not apply anymore as I don't see it updated

Would you be willing to update it? I have no ppc(64)(le) hardware to test with. Debian appears to be using this patch: https://salsa.debian.org/lua-team/luajit/-/blob/master/debian/patches/0004-Add-ppc64-support-based-on-koriakin-GitHub-patchset.patch

@triallax
Copy link
Contributor

How about https://github.com/openresty/luajit2, which does have releases and is used by e.g. Homebrew as a replacement for upstream LuaJIT?

@gbrlsnchs
Copy link
Contributor

How about https://github.com/openresty/luajit2, which does have releases and is used by e.g. Homebrew as a replacement for upstream LuaJIT?

That would solve the "bus factor" issue, at least. 😅

@Idesmi
Copy link
Contributor

Idesmi commented Apr 22, 2022

Alpine builds on OpenResty's tag release as well.

@kartikynwa
Copy link
Contributor

How about https://github.com/openresty/luajit2, which does have releases and is used by e.g. Homebrew as a replacement for upstream LuaJIT?

this is dope

@LinArcX

This comment was marked as off-topic.

@Idesmi
Copy link
Contributor

Idesmi commented Apr 23, 2022

I still don't understand why maintainers of void insist on release versions of applications.

I believe it's meant to relieve considerable burden from the project.

@q66
Copy link
Contributor

q66 commented Apr 23, 2022

I would be okay with taking the openresty fork by the way, though we would need to test if ppc32 is still broken there (or i could drop it)

@kartikynwa
Copy link
Contributor

Any update on the discussion regarding this?

@CameronNemo
Copy link
Contributor Author

I think the consensus is to switch to the openresty upstream.

@mitinarseny
Copy link

also related: neovim/neovim#17562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants