Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): add syntax file for query #18101

Merged
merged 1 commit into from
Apr 13, 2022
Merged

fix(runtime): add syntax file for query #18101

merged 1 commit into from
Apr 13, 2022

Conversation

clason
Copy link
Member

@clason clason commented Apr 13, 2022

followup to #17905: also use Lisp syntax for treesitter queries

@clason clason added the runtime funtime label Apr 13, 2022
@clason clason requested a review from gpanders April 13, 2022 09:22
runtime/syntax/query.lua Outdated Show resolved Hide resolved
followup to #17905: also use Lisp syntax for treesitter queries
@clason clason requested a review from zeertzjq April 13, 2022 10:23
@zeertzjq
Copy link
Member

zeertzjq commented Apr 13, 2022

Hmm, I think only very few Lisp keywords are treesitter query keywords, which makes the highlighting look a bit strange:
Screenshot_20220413_183542

@clason
Copy link
Member Author

clason commented Apr 13, 2022

It think it looks fine? Certainly better than no highlighting at all (especially for comments)... It's mostly meant as a fallback for people who don't have tree-sitter activated.

(The alternative would be to write a custom syntax file, and that is certainly not worth the effort.)

@clason clason requested a review from vigoux April 13, 2022 13:59
@clason clason merged commit 7d1142b into neovim:master Apr 13, 2022
@clason clason deleted the query-ft branch April 13, 2022 14:29
@github-actions github-actions bot removed the request for review from gpanders April 13, 2022 14:30
dmitmel pushed a commit to dmitmel/neovim that referenced this pull request Apr 16, 2022
followup to neovim#17905: also use Lisp syntax for treesitter queries
kraftwerk28 pushed a commit to kraftwerk28/neovim that referenced this pull request Jun 1, 2022
followup to neovim#17905: also use Lisp syntax for treesitter queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime funtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants