Build failure ‘msgpack_object_union’ has no member named ‘dec’

[JelteF]

I can't get the current source to build. Doing this on Gentoo with the ebuild from the lua overlay and GCC 4.9.2

<built-in>: note: this is the location of the previous definition
/var/tmp/portage/app-editors/neovim-9999/work/neovim-9999/src/nvim/msgpack_rpc/helpers.c: In function ‘msgpack_rpc_to_float’:
/var/tmp/portage/app-editors/neovim-9999/work/neovim-9999/src/nvim/msgpack_rpc/helpers.c:89:18: error: ‘msgpack_object_union’ has no member named ‘dec’
   *arg = obj->via.dec;
                  ^
/var/tmp/portage/app-editors/neovim-9999/work/neovim-9999/src/nvim/msgpack_rpc/helpers.c:90:23: error: ‘MSGPACK_OBJECT_DOUBLE’ undeclared (first use in this function)
   return obj->type == MSGPACK_OBJECT_DOUBLE;
                       ^
/var/tmp/portage/app-editors/neovim-9999/work/neovim-9999/src/nvim/msgpack_rpc/helpers.c:90:23: note: each undeclared identifier is reported only once for each function it appears in
/var/tmp/portage/app-editors/neovim-9999/work/neovim-9999/src/nvim/msgpack_rpc/helpers.c: In function ‘msgpack_rpc_to_object’:
/var/tmp/portage/app-editors/neovim-9999/work/neovim-9999/src/nvim/msgpack_rpc/helpers.c:123:10: error: ‘MSGPACK_OBJECT_DOUBLE’ undeclared (first use in this function)
     case MSGPACK_OBJECT_DOUBLE:
          ^
/var/tmp/portage/app-editors/neovim-9999/work/neovim-9999/src/nvim/msgpack_rpc/helpers.c: In function ‘msgpack_rpc_to_float’:
/var/tmp/portage/app-editors/neovim-9999/work/neovim-9999/src/nvim/msgpack_rpc/helpers.c:91:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
src/nvim/CMakeFiles/nvim.dir/build.make:2795: recipe for target 'src/nvim/CMakeFiles/nvim.dir/msgpack_rpc/helpers.c.o' failed
make[2]: *** [src/nvim/CMakeFiles/nvim.dir/msgpack_rpc/helpers.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/var/tmp/portage/app-editors/neovim-9999/work/neovim-9999/src/nvim/msgpack_rpc/channel.c: In function ‘job_err’:
/var/tmp/portage/app-editors/neovim-9999/work/neovim-9999/src/nvim/msgpack_rpc/channel.c:346:12: warning: unused variable ‘channel’ [-Wunused-variable]
   Channel *channel = job_data(data);
            ^

[JelteF]

It seems this msgpack/msgpack-c#191 has something to do with it.
This probably fixes it: https://github.com/msgpack/msgpack-c/wiki/cpp_configure

[ghost]

I've always had this issue when building with msgpack-c from git, and IIRC you aren't supposed to do that. Currently, it seems like a specific msgpack revision should be used, like what's done in this pkgbuild, although I think passing the cpp flag you mentioned would be a more elegant way of dealing with things.

It doesn't look like it'd be too hard to update to the new names in the float format family, detailed in msgpack/msgpack-c@737e670).

[ghost]

Yep, builds fine with that cpp flag. I've no idea how to pass arbitrary flags to cmake on the command line, so I did this:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 42eb50a..87fdf02 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -141,6 +141,7 @@ endif()

 add_definitions(-DINCLUDE_GENERATED_DECLARATIONS)
 add_definitions(-DHAVE_CONFIG_H)
+add_definitions(-DMSGPACK_USE_LEGACY_NAME_AS_FLOAT)

 if(CMAKE_COMPILER_IS_GNUCXX AND CMAKE_SYSTEM_NAME STREQUAL "Linux")
   set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,--no-undefined")

[ghost]

@JelteF I submitted a PR, let me know if the commit over there fixes your issue.

[ghost]

ping @JelteF

[JelteF]

Sorry for the late response, it works when I change the repo to your fork.

[ghost]

Good to hear.