Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Fix build failure using newer versions of msgpack-c #1900

Closed
wants to merge 1 commit into from
Closed

[RFC] Fix build failure using newer versions of msgpack-c #1900

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 28, 2015

Here's the relevant issue and commit in the msgpack-c issue tracker:
msgpack/msgpack-c#191
msgpack/msgpack-c@737e670

@ghost ghost changed the title msgpack-c: Update to new API [RFC] msgpack-c: Update to new API Jan 28, 2015
@marvim marvim added the RFC label Jan 28, 2015
@ghost ghost changed the title [RFC] msgpack-c: Update to new API [RFC] Fix build failure using newer versions msgpack-c Feb 7, 2015
@ghost ghost changed the title [RFC] Fix build failure using newer versions msgpack-c [RFC] Fix build failure using newer versions of msgpack-c Feb 7, 2015
@ghost
Copy link
Author

ghost commented Feb 7, 2015

Repushed with a newer version of msgpack-c, which fixes msgpack/msgpack-c#209.

@justinmk
Copy link
Member

justinmk commented Feb 7, 2015

restarted OS X build

justinmk
justinmk reviewed Feb 7, 2015
View reviewed changes
.travis.yml
@@ -5,7 +5,7 @@ env:
global:
- CI_SCRIPTS=$TRAVIS_BUILD_DIR/.ci
# To build third-party dependencies, set this to 'true'.
- BUILD_NVIM_DEPS=false
- BUILD_NVIM_DEPS=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is temporary, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@justinmk
Copy link
Member

justinmk commented Feb 7, 2015

LGTM. @tarruda could you peek at this?

@justinmk
Copy link
Member

justinmk commented Feb 7, 2015

@pyrohh Did you test this with the python client? E.g., just verify that a python plugin like YCM or ultisnips works as usual.

@ghost
Copy link
Author

ghost commented Feb 7, 2015

@justinmk Just tried out UltiSnips and it works fine using the latest python client.

@justinmk
Copy link
Member

justinmk commented Feb 7, 2015

Just looked around, I didn't see any commits since msgpack/msgpack-c@ecf4b09 that would be a problem for us.

@ghost
Copy link
Author

ghost commented Feb 9, 2015

Ooh! Great to see Coveralls working.

@ghost ghost mentioned this pull request Feb 9, 2015
Closed
@justinmk justinmk added the api libnvim, Nvim RPC API label Feb 10, 2015
@justinmk
Copy link
Member

Coveralls really needs a "threshold" or epsilon value, to avoid noise.

@pyrohh If you can send a similar PR to https://github.com/neovim/homebrew-neovim , and remove the temp commit here, I see no reason not to merge this...

@ghost
Copy link
Author

ghost commented Feb 10, 2015

Done, gonna do the homebrew one now.

@justinmk justinmk mentioned this pull request Feb 10, 2015
Closed
3 tasks
@ghost ghost mentioned this pull request Feb 10, 2015
Merged
@ghost
Copy link
Author

ghost commented Feb 10, 2015

done

@justinmk
Copy link
Member

here we go...

justinmk pushed a commit that referenced this pull request Feb 10, 2015
@justinmk
build: upgrade msgpack-c #1900
ec5e945 
closes #1899
closes #1967

refs msgpack/msgpack-c#194
@justinmk
Copy link
Member

merged. Going to run bot-ci now.

@justinmk justinmk closed this Feb 10, 2015
@justinmk justinmk removed the RFC label Feb 10, 2015
@ghost ghost deleted the update-msgpack-c branch February 10, 2015 05:06
@jszakmeister
Copy link
Contributor

FYI: this update broke FreeBSD

00:12:08,664 INFO  - /usr/home/quickbuild/buildagent/workspace/root/neovim/master/.deps/build/src/msgpack/include/msgpack/sysdep.h:80:14: fatal error: 'byteswap.h' file not found
00:12:08,664 INFO  - # include <byteswap.h>
00:12:08,664 INFO  - ^

@jszakmeister
Copy link
Contributor

I added a comment to msgpack/msgpack-c#221. Hopefully it will get fixed soonish.

@justinmk
Copy link
Member

@jszakmeister great to see quick feedback from your bsd builds!

@jszakmeister
Copy link
Contributor

@justinmk I'm hoping to get my QuickBuild instance in a position that it can be reached by others and have it start checking pull requests too. I still have a few issues to sort out though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api libnvim, Nvim RPC API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinmk @jszakmeister @marvim