Windows: install has insufficient privileges after admin password

[DeadRobotDev]

Problem

Tried to update to the latest rebuild from an old nightly. It failed, stating it had insufficient privileges to access cat.exe, I think.

Uninstalled the previous version in case that was an issue. Still fails to install, stating it has insufficient privileges to access C:\Program Files\Neovim.

I believe it is related to the UAC prompt. In the nightly build, it mentionsnvim-win64.msi in the UAC prompt. In the release build, it mentions C:\Windows\Installer\3a5b0f68.msi. And not always the same string.

Steps to reproduce

1. Run nvim-win64.msi on a non-admin account.
2. Install to default location, C:\Program Files\Neovim.
3. At "Removing applications", it asks for admin privileges for C:\Windows\Installer\3a5b0f68.msi. Enter the password.
4. At "Copying new files", it says it has insufficient privileges to access the directory.

Expected behavior

I enter the password for admin privileges, and it installs correctly to C:\Program Files\Neovim.

It worked on NVIM v0.9.0-dev-1166+g06aed7c17, which is the last nightly I installed before the release build.

Neovim version (nvim -v)

0.9.0

Vim (not Nvim) behaves the same?

NA

Operating system/version

Windows 10 Home 19045.2728

Terminal name/version

alacritty 0.12.0 (5a728195)

$TERM environment variable

xterm-256color

Installation

Repo .msi

[dundargoc]

May be caused by #22856

[rollingmoai]

There should be an option in the installer to install per-user or per-machine, like this:

Maybe we can revert this part for a while?

neovim/cmake.packaging/WixPatch.xml

Lines 15 to 20 in bc66b75

	<!-- Allow installation by non-administrative users -->
	<!-- https://learn.microsoft.com/windows/win32/msi/allusers -->
	<CPackWiXFragment Id="#PRODUCT">
	<Property Id="ALLUSERS" Value="2" />
	<Property Id="MSIINSTALLPERUSER" Value="1" />
	</CPackWiXFragment>

[RomanoZumbe]

I just tried to update nvim on a windows machine and encounter this issue with the current release version

[winter-again]

I'm having the same issue.

[dundargoc]

Does uninstalling and then installing work?

[winter-again]

Does uninstalling and then installing work?

Thanks, this worked for me. Looks like the install location changed, correct? Is this something to look out for when updating via .msi in the future?

[RomanoZumbe]

Does uninstalling and then installing work?

It did work. Thanks!

[dundargoc]

Thanks, this worked for me. Looks like the install location changed, correct? Is this something to look out for when updating via .msi in the future?

Not intentionally, no.

[kepplingerstephan]

Had same issue while updating on windows

after deinstalling old version, installer worked

[ikopysov]

Had the same issue, but there was no option to remove previous version - I was not able to find it under "Add or remove programs" menu.
Also there was no option to run it as admin user.
Compatibility settings also not available (all of them disabled).

Was able to install it using sudo ii ".\nvim.msi" in pwsh using sudo from https://github.com/lukesampson/psutils

Hope it will help someone.