Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs refer to vim.lsp.buf_request() that is no longer documented #23353

Closed
ddickstein opened this issue Apr 27, 2023 · 4 comments · Fixed by #24061
Closed

Docs refer to vim.lsp.buf_request() that is no longer documented #23353

ddickstein opened this issue Apr 27, 2023 · 4 comments · Fixed by #24061
Assignees

Comments

@ddickstein
Copy link
Contributor

ddickstein commented Apr 27, 2023

Problem

The docs for vim.lsp.buf_request have been removed, but there are still various references to it in lsp.txt. It seems like there is also a vim.lsp.buf_request function that exists (it's not nil) so I'm not sure what the intended current state is.

Neovim version (nvim -v)

v0.10.0-dev-186+g191e8b406

Vim (not Nvim) behaves the same?

N/A

Operating system/version

Rocky Linux 8.6

Terminal name/version

xfce4-terminal 1.0.4

$TERM environment variable

tmux-256color

Installation

appimage

@ddickstein ddickstein added the bug issues reporting wrong behavior label Apr 27, 2023
@clason clason added documentation lsp and removed bug issues reporting wrong behavior labels Apr 27, 2023
@clason
Copy link
Member

clason commented Apr 27, 2023

PR fixing that is welcome. (References should be removed or changed to buf_request_all().)

@mfussenegger
Copy link
Member

See also #19738 for the rationale behind the removal from the docs.

@justinmk justinmk self-assigned this Jun 19, 2023
@justinmk justinmk mentioned this issue Jun 19, 2023
2 tasks
@justinmk
Copy link
Member

Fixed in #24061.

It is also time to deprecate vim.lsp.start_client in favor of vim.lsp.start() ?

@clason
Copy link
Member

clason commented Jun 19, 2023

I don't think vim.lsp.start() is a complete replacement; start_client is lower-level (and used by start(), as well as nvim-lspconfig).

(End-user documentation should of course promote start over start_client.)

justinmk added a commit that referenced this issue Jun 19, 2023
- nvim requires rpc responses in reverse order. #19932
- NVIM_APPNAME: UIs normally should NOT set this.

ref #23520
fix #24050
fix #23660
fix #23353
fix #23337
fix #22213
fix #19161
fix #18088
fix #20693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants