-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The culling of vim.lsp.util #25272
Comments
|
Looks like it was due to testing: 9a67b03
There is some discussion around introducing a
Another potential alternative would be to mix this into some kind of position or range abstraction. I have some vague idea about that, but won't be able to try it anytime soon. +1 for all the others. |
Reference: #25509 💯 for the other suggestions in this issue, with these comments:
|
But it renders markdown as text, so (I'm wary of opening the floodgates for shoving functionality into 👍 for Taking |
I've no objection, though having more of this done in Lua rather than in C might be nice.
That seems reasonable to me. |
I created #25514 to track the |
To reduce cross-chatter between modules and for neovim#25272 Also preparing for neovim#25714
To reduce cross-chatter between modules and for neovim#25272 Also preparing for neovim#25714
To reduce cross-chatter between modules and for neovim#25272 Also preparing for neovim#25714
To reduce cross-chatter between modules and for neovim#25272 Also preparing for neovim#25714
Problem: `vim.lsp.buf.definition()` throws an error if prompt is shown while opening a file (specifically the "E325: ATTENTION" swapfile prompt). Error executing vim.schedule lua callback: …/runtime/lua/vim/lsp/util.lua:1074: Cursor position outside buffer stack traceback: [C]: in function 'nvim_win_set_cursor' …/runtime/lua/vim/lsp/util.lua:1074: in function 'jump_to_location' …/runtime/lua/vim/lsp/handlers.lua:423: in function 'handler' …/runtime/lua/vim/lsp.lua:1517: in function '' vim/_editor.lua: in function <vim/_editor.lua:0> Solution: Handle `nvim_win_set_cursor` failure. See also: neovim#25272
Problem: `vim.lsp.buf.definition()` throws an error if prompt is shown while opening a file (specifically the "E325: ATTENTION" swapfile prompt). Error executing vim.schedule lua callback: …/runtime/lua/vim/lsp/util.lua:1074: Cursor position outside buffer stack traceback: [C]: in function 'nvim_win_set_cursor' …/runtime/lua/vim/lsp/util.lua:1074: in function 'jump_to_location' …/runtime/lua/vim/lsp/handlers.lua:423: in function 'handler' …/runtime/lua/vim/lsp.lua:1517: in function '' vim/_editor.lua: in function <vim/_editor.lua:0> Solution: Handle `nvim_win_set_cursor` failure. See also: neovim#25272
Problem
vim.lsp.util
is a dumpster that needs to be cleaned up. This process has already been started in #25073. But the pruning must continue.This is a tracking issue for substantially reducing the size and scope of
vim.lsp.util
. Ideally, it will be removed completely (deprecated first, of course, and removed in a future release).In particular, new homes should be found for:
_normalize_markdown
vim.lsp.util
. TBD on the correct namespace for thisopen_floating_preview
vim.ui.open_win
. (vim.ui enhancements: proposal and tracking issue #25514)make_floating_popup_options
vim.ui.open_float
. Deprecate._make_floating_popup_size
_str_utfindex_enc
and_str_byteindex_enc
vim.str_utfindex
andvim.str_byteindex
, respectively. Consider updating those functions to accept an encoding instead.set_lines
apply_text_edits
vim.lsp.buf
? @mfussenegger_get_completion_item_kind_name
text_document_completion_list_to_complete_items
stylize_markdown
normalize_markdown
is public andvim.ui.open_float
exists. At that point this is no longer needed or necessary.The list above is non-exhaustive, it may be updated with new items as the effort progresses.
The text was updated successfully, but these errors were encountered: