Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra line break after indent when settings wrap, linebreak and breakindent are enabled #25276

Closed
EtiamNullam opened this issue Sep 20, 2023 · 1 comment · Fixed by #25604
Closed

Extra line break after indent when settings wrap, linebreak and breakindent are enabled #25276

EtiamNullam opened this issue Sep 20, 2023 · 1 comment · Fixed by #25604
Labels
enhancement feature request has:vim-patch issue is fixed in vim and patch needs to be ported
Milestone
0.10

Comments

@EtiamNullam
Copy link

EtiamNullam commented Sep 20, 2023 •
edited
Loading

Problem

There is useless line break between whitespaces and a long text when settings wrap, linebreak and breakindent are enabled.

image

That extra break only makes sense when breakindent is disabled: that extra linebreak between whitespaces and the visible text is making sure there is more space available for the text, but when breakindent is enabled then text is (virtually) indented with the same amount of padding as the whitespaces in before the linebreak.

Steps to reproduce

nvim -u NONE
:set wrap linebreak breakindent
ia
1000.
V>

Expected behavior

There should be no line break between whitespaces and the text and it should look just like linebreak is disabled in this case.

image

Neovim version (nvim -v)

NVIM v0.10.0-dev-1031-gc431d820e

Vim (not Nvim) behaves the same?

yes, 9.0

Operating system/version

Windows 10

Terminal name/version

cmder 1.3.21

$TERM environment variable

N/A

Installation

Scoop
@EtiamNullam EtiamNullam added the bug issues reporting wrong behavior label Sep 20, 2023
@zeertzjq zeertzjq added bug-vim wrong behavior inherited from vim enhancement feature request and removed bug issues reporting wrong behavior bug-vim wrong behavior inherited from vim labels Sep 20, 2023
@justinmk justinmk added this to the unplanned milestone Sep 21, 2023
@justinmk justinmk added the needs:vim-patch upstream issue that must be fixed in Vim first label Sep 21, 2023
@EtiamNullam
Copy link
Author

I've raised this issue also on vim/vim: vim/vim#13228

@zeertzjq zeertzjq mentioned this issue Oct 11, 2023
Merged
@zeertzjq zeertzjq added has:vim-patch issue is fixed in vim and patch needs to be ported and removed needs:vim-patch upstream issue that must be fixed in Vim first labels Oct 11, 2023
@zeertzjq zeertzjq modified the milestones: unplanned, 0.10 Oct 11, 2023
@vanaigr vanaigr mentioned this issue Jan 21, 2024
Merged
vanaigr added a commit to vanaigr/neovim that referenced this issue Jan 24, 2024
@vanaigr
test: modify Test_linebreak_no_break_after_whitespace_only()
4f1fcb8 
Add space after the first tab to verify that neovim#25276 could still happen
vanaigr added a commit to vanaigr/neovim that referenced this issue Jan 24, 2024
@vanaigr
test: modify Test_linebreak_no_break_after_whitespace_only()
5b25d9b 
Add space after the first tab to verify that neovim#25276 could still happen
@vanaigr vanaigr mentioned this issue Jan 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature request has:vim-patch issue is fixed in vim and patch needs to be ported
Projects
None yet
Milestone
0.10
Development

Successfully merging a pull request may close this issue.

vim-patch:9.0.2017: linebreak applies for leading whitespace zeertzjq/neovim
3 participants
@justinmk @EtiamNullam @zeertzjq