Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make make format work during rebase #25654

Closed
dundargoc opened this issue Oct 15, 2023 · 1 comment · Fixed by #25758
Closed

Make make format work during rebase #25654

dundargoc opened this issue Oct 15, 2023 · 1 comment · Fixed by #25758
Labels
build building and installing Neovim using the provided scripts complexity:low Low-risk, self-contained. Do NOT ask "can I work on this", just read CONTRIBUTING.md
Milestone
0.10

Comments

@dundargoc
Copy link
Member

dundargoc commented Oct 15, 2023 •
edited

make format does not work during rebasing. This is because it tries to be smart ans only format files which have been changed in PR, but this breaks down during rebase. Ideally it'd still be able to detect which files were changed even on rebase, but a fallback to formatting all files instead is also acceptable.

The formatting logic is in cmake/Format.cmake
@zeertzjq zeertzjq added the build building and installing Neovim using the provided scripts label Oct 15, 2023
@dundargoc dundargoc added complexity:low Low-risk, self-contained. Do NOT ask "can I work on this", just read CONTRIBUTING.md build building and installing Neovim using the provided scripts and removed build building and installing Neovim using the provided scripts labels Oct 15, 2023
@patriciarodrigues151
Copy link

Hi, I'm working on this.

@justinmk justinmk added this to the backlog milestone Oct 16, 2023
dundargoc added a commit to dundargoc/neovim that referenced this issue Oct 23, 2023
@dundargoc
build: enable formatting during rebase
a61b7ed 
Closes neovim#25654
@dundargoc dundargoc mentioned this issue Oct 23, 2023
Merged
dundargoc added a commit to dundargoc/neovim that referenced this issue Oct 23, 2023
@dundargoc
build: enable formatting during rebase
e20631c 
Closes neovim#25654
dundargoc added a commit that referenced this issue Oct 23, 2023
@dundargoc
build: enable formatting during rebase
25cfe3f 
Closes #25654
@zeertzjq zeertzjq modified the milestones: backlog, 0.10 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build building and installing Neovim using the provided scripts complexity:low Low-risk, self-contained. Do NOT ask "can I work on this", just read CONTRIBUTING.md
Projects
CI, Build and Automation
Status: Done
Milestone
0.10
Development

Successfully merging a pull request may close this issue.

build: enable formatting during rebase dundargoc/neovim
4 participants
@justinmk @dundargoc @zeertzjq @patriciarodrigues151