Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New colorscheme] winbar highlights link to statusline #26502

Closed
geril2207 opened this issue Dec 10, 2023 · 2 comments
Closed

[New colorscheme] winbar highlights link to statusline #26502

geril2207 opened this issue Dec 10, 2023 · 2 comments
Labels
bug issues reporting wrong behavior defaults issues or PRs involving changing the defaults

Comments

@geril2207
Copy link

geril2207 commented Dec 10, 2023

Problem

The WinBar and WinBarNC highlight groups are now linked to StatusLine and StatusLineNC after new colorscheme refactoring. Can I change the StatusLine/NC highlight without affecting WinBar and WinBarNC(what should we do from plugin)? What are your thoughts on that? I believe there are currently some issues in other plugins because of this, for example, nvim-tree/nvim-tree.lua#2582. Additionally, colorscheme plugins should handle WinBar and WinBarNC(not a big deal). I don't think it should have the same background as the statusline; what do you think?

Steps to reproduce

Actually this is a question, i dont think you need to reproduce smth.

Expected behavior

I should have make it question, but I feel that it does not get answer :)

Neovim version (nvim -v)

latest master

Vim (not Nvim) behaves the same?

na

Operating system/version

Arch

Terminal name/version

kitty

$TERM environment variable

xterm-kitty

Installation

from source

@geril2207 geril2207 added the bug issues reporting wrong behavior label Dec 10, 2023
@wookayin
Copy link
Member

wookayin commented Dec 10, 2023

❯❯❯ nvim-0.9.4 --clean --headless -c 'hi WinBar' -c q

WinBar         xxx cterm=bold gui=bold


❯❯❯ nvim --clean --headless -c 'hi WinBar' -c q 

WinBar         xxx links to StatusLine


❯❯❯ nvim --clean --headless -c 'hi StatusLine' -c q 

StatusLine     xxx ctermfg=251 ctermbg=232 guifg=NvimLightGrey3 guibg=NvimDarkGrey1

You can do highlight WinBar ctermfg=NONE ctermbg=NONE guifg=NONE guibg=NONE cterm=bold gui=bold to reset to the old defaults in your config or colorscheme. Personally I think the new defaults of Winbar linked to StatusLine makes sense and I'd agree with that, but yes, it has a breaking impact on the existing colorscheme that did not define Winbar explicitly. I think this is just a matter of user config or plugins should adopt to the new colorscheme change. See also #26378 and #26369.

@glepnir glepnir added the defaults issues or PRs involving changing the defaults label Dec 10, 2023
@geril2207
Copy link
Author

Yeah, thanks, agree with this for default theme, but for plugins and themes it provides a little of mess.

@geril2207 geril2207 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
Bekaboo pushed a commit to Bekaboo/nvim that referenced this issue Dec 30, 2023
Bug:    The new default theme sets background color for 'hl-WinBar',
        making the highlighted chunk looks a bit off. Also see

        neovim/neovim#26037
        neovim/neovim#26502

Fix:    Clear background of 'hl-WinBar' and 'hl-WinBarNC' automatically
        on colorscheme change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues reporting wrong behavior defaults issues or PRs involving changing the defaults
Projects
None yet
Development

No branches or pull requests

3 participants