Make :confirm bd work for terminal buffers

[blueyed]

It would be nice if :confirm bd would work as with a changed buffer: it should ask for confirmation instead of requiring you to use :bd!:

E89: term://.//15810:… will be killed(add ! to override)

Relevant code:

neovim/src/nvim/buffer.c

Lines 953 to 975 in ef205c3

	if (!forceit && (buf->terminal || bufIsChanged(buf))) {
	if ((p_confirm || cmdmod.confirm) && p_write && !buf->terminal) {
	dialog_changed(buf, FALSE);
	if (!buf_valid(buf))
	/* Autocommand deleted buffer, oops! It's not changed
	* now. */
	return FAIL;
	/* If it's still changed fail silently, the dialog already
	* mentioned why it fails. */
	if (bufIsChanged(buf))
	return FAIL;
	} else {
	if (buf->terminal) {
	EMSG2(_("E89: %s will be killed(add ! to override)"),
	(char *)buf->b_fname);
	} else {
	EMSGN(_("E89: No write since last change for buffer %" PRId64
	" (add ! to override)"),
	buf->b_fnum);
	}
	return FAIL;
	}
	}

.

Here !buf->terminal is checked for in the block that uses the dialog.
I think there could be a new dialog_terminal_kill for this.

• Neovim version: v0.1.5-24-gef205c3

[Asheq]

Also, I think that if the confirm option is set, :bd should behave the same as :confirm bd