Neovim stopped building on OpenBSD -current

[xstrtok]

• nvim --version: NVIM v0.2.0-611-gf017ae61
• Vim (version: ) behaves differently? everything after commit f017ae6 until commit 3a2ae17
• Operating system/version: OpenBSD 6.0-current (amd64)

I've switched to Neovim for the last ~2 months. Building using instructions from here and until recently, all went smooth.

Last version I can build, is f017ae6

Commit c1bc784 seems to break the build on OpenBSD.

Output:

[ 50%] Generating auto/unicode_tables.generated.h
Scanning dependencies of target nvim
[ 50%] Building C object src/nvim/CMakeFiles/nvim.dir/__/__/config/auto/pathdef.c.o
In file included from /home/cipher/devel/tools/neovim/src/nvim/strings.h:11,
                 from /home/cipher/devel/tools/neovim/src/nvim/keymap.h:4,
                 from /home/cipher/devel/tools/neovim/src/nvim/vim.h:46,
                 from /home/cipher/devel/tools/neovim/build/config/auto/pathdef.c:1:
/home/cipher/devel/tools/neovim/build/include/strings.h.generated.h:26: error: expected declaration specifiers or '...' before 'va_list'
In file included from /home/cipher/devel/tools/neovim/src/nvim/buffer_defs.h:19,
                 from /home/cipher/devel/tools/neovim/src/nvim/normal.h:6,
                 from /home/cipher/devel/tools/neovim/src/nvim/ex_cmds_defs.h:8,
                 from /home/cipher/devel/tools/neovim/src/nvim/ex_eval.h:5,
                 from /home/cipher/devel/tools/neovim/src/nvim/globals.h:8,
                 from /home/cipher/devel/tools/neovim/src/nvim/vim.h:314,
                 from /home/cipher/devel/tools/neovim/build/config/auto/pathdef.c:1:
/home/cipher/devel/tools/neovim/src/nvim/garray.h: In function 'ga_append_via_ptr':
/home/cipher/devel/tools/neovim/src/nvim/garray.h:40: warning: passing argument 4 of 'do_log' with different width due to prototype
In file included from /home/cipher/devel/tools/neovim/src/nvim/memory.h:41,
                 from /home/cipher/devel/tools/neovim/src/nvim/lib/khash.h:133,
                 from /home/cipher/devel/tools/neovim/src/nvim/map_defs.h:4,
                 from /home/cipher/devel/tools/neovim/src/nvim/map.h:6,
                 from /home/cipher/devel/tools/neovim/src/nvim/buffer_defs.h:39,
                 from /home/cipher/devel/tools/neovim/src/nvim/normal.h:6,
                 from /home/cipher/devel/tools/neovim/src/nvim/ex_cmds_defs.h:8,
                 from /home/cipher/devel/tools/neovim/src/nvim/ex_eval.h:5,
                 from /home/cipher/devel/tools/neovim/src/nvim/globals.h:8,
                 from /home/cipher/devel/tools/neovim/src/nvim/vim.h:314,
                 from /home/cipher/devel/tools/neovim/build/config/auto/pathdef.c:1:
/home/cipher/devel/tools/neovim/build/include/memory.h.generated.h: At top level:
/home/cipher/devel/tools/neovim/build/include/memory.h.generated.h:7: warning: 'alloc_size' attribute directive ignored
/home/cipher/devel/tools/neovim/build/include/memory.h.generated.h:8: warning: 'alloc_size' attribute directive ignored
/home/cipher/devel/tools/neovim/build/include/memory.h.generated.h:9: warning: 'alloc_size' attribute directive ignored
/home/cipher/devel/tools/neovim/build/include/memory.h.generated.h:11: warning: 'alloc_size' attribute directive ignored
/home/cipher/devel/tools/neovim/build/include/memory.h.generated.h:12: warning: 'alloc_size' attribute directive ignored
/home/cipher/devel/tools/neovim/build/include/memory.h.generated.h:28: warning: 'alloc_size' attribute directive ignored
In file included from /home/cipher/devel/tools/neovim/src/nvim/globals.h:14,
                 from /home/cipher/devel/tools/neovim/src/nvim/vim.h:314,
                 from /home/cipher/devel/tools/neovim/build/config/auto/pathdef.c:1:
/home/cipher/devel/tools/neovim/src/nvim/event/loop.h: In function 'kmp_init_WatcherPtr':
/home/cipher/devel/tools/neovim/src/nvim/event/loop.h:15: warning: passing argument 1 of 'xcalloc' with different width due to prototype
/home/cipher/devel/tools/neovim/src/nvim/event/loop.h: In function 'kmp_alloc_WatcherPtr':
/home/cipher/devel/tools/neovim/src/nvim/event/loop.h:15: warning: passing argument 1 of 'xcalloc' with different width due to prototype
/home/cipher/devel/tools/neovim/src/nvim/event/loop.h: In function 'kl_init_WatcherPtr':
/home/cipher/devel/tools/neovim/src/nvim/event/loop.h:15: warning: passing argument 1 of 'xcalloc' with different width due to prototype
gmake[2]: *** [src/nvim/CMakeFiles/nvim.dir/build.make:1063: src/nvim/CMakeFiles/nvim.dir/__/__/config/auto/pathdef.c.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:356: src/nvim/CMakeFiles/nvim.dir/all] Error 2
gmake: *** [Makefile:150: all] Error 2

Above output, is from latest master branch.

[xstrtok]

Thank you for the patch.

Pulled the latest changes, removed {.deps,build} directory to build again and problem persists with the exact same error output.

Pebcac maybe or am I missing something?

[jamessan]

Ah, no, I didn't read the error message close enough. I added stdarg.h to strings.c (which was needed) but forgot to also add it to strings.h.

[jamessan]

Should be fixed now.

[xstrtok]

Confirming that this commit fixes build on OpenBSD.

Thank you.