Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: CTRL-F with 'scrolloff' #6319

Closed
justinmk opened this issue Mar 19, 2017 · 0 comments · Fixed by #6327
Closed

regression: CTRL-F with 'scrolloff' #6319

justinmk opened this issue Mar 19, 2017 · 0 comments · Fixed by #6327
Labels
bug issues reporting wrong behavior complexity:low Low-risk, self-contained. Do NOT ask "can I work on this", just read CONTRIBUTING.md
Milestone
backlog

Comments

@justinmk
Copy link
Member

See #6318 (comment)

Test_normal14_page is marked as "skip", but it demonstrates a regression compared to Vim. In a window of height=10,

   1
   set scrolloff=99
   exe "norm! \<c-f>"
   call assert_equal('13', getline('.'))

The cursor goes to line 9 instead of 13. Seems like Nvim is placing the cursor before adjusting for 'scrolloff' relative to the window size.
@justinmk justinmk added the bug issues reporting wrong behavior label Mar 19, 2017
@justinmk justinmk added this to the todo milestone Mar 19, 2017
@justinmk justinmk added the complexity:low Low-risk, self-contained. Do NOT ask "can I work on this", just read CONTRIBUTING.md label Mar 19, 2017
lonerover added a commit to lonerover/neovim that referenced this issue Mar 21, 2017
@lonerover
move.c: add cursor adjustment for scrolloff (neovim#6319)
7418adc
@lonerover lonerover mentioned this issue Mar 21, 2017
Merged
jamessan added a commit that referenced this issue Mar 21, 2017
@jamessan
Merge pull request #6327 from lonerover/issue-#6319
5657bb9 
[RFC] fix the behavior of CTRL-F with 'scrolloff' (#6319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug issues reporting wrong behavior complexity:low Low-risk, self-contained. Do NOT ask "can I work on this", just read CONTRIBUTING.md
Projects
None yet
Milestone
backlog
Development

Successfully merging a pull request may close this issue.

[RFC] fix the behavior of CTRL-F with 'scrolloff' (#6319) lonerover/neovim
1 participant
@justinmk