vim-patch:8.0.1119: quitting a split terminal window kills the job

[blueyed]

Problem: Quitting a split terminal window kills the job. (Yasuhiro
Matsumoto)
Solution: Only stop terminal job if it is the last window.
vim/vim@8adb0d0

The flow is a bit different there in nvim already, but this brings the code in line.

TODO:

• explicit test
• vim-8.0.1732.patch / vim-8.1.0342.patch (?)

Should/could we have testdir/test_terminal.vim in general to see/test that certain behavior is consistent with Vim?

[blueyed]

Affected test:

[  ERROR   ] 1 error, listed below:
[  ERROR   ] ...ojects/neovim/test/functional\autocmd\termclose_spec.lua @ 76: TermClose event reports the correct <abuf>
test\functional\helpers.lua:96: Vim(bdelete):E16: Invalid range
stack traceback:
	test\functional\helpers.lua:96: in function 'request'
	test\functional\helpers.lua:254: in function 'command'
	...ojects/neovim/test/functional\autocmd\termclose_spec.lua:89: in function <...ojects/neovim/test/functional\autocmd\termclose_spec.lua:76>

[justinmk]

Should/could we have testdir/test_terminal.vim in general to see/test that certain behavior is consistent with Vim?

No. why? :terminal is tested in Lua, and matching Vim's :terminal behavior is not a goal.

[janlazo]

This is missing 8.0.0953

--- a/src/buffer.c
+++ b/src/buffer.c
@@ -473,8 +473,8 @@ close_buffer(
    {
	if (term_job_running(buf->b_term))
	{
--	    if (wipe_buf)
--		/* Wiping out a terminal buffer kills the job. */
++	    if (wipe_buf || unload_buf)
++		/* Wiping out or unloading a terminal buffer kills the job. */
		free_terminal(buf);
	    else
	    {

[jcorbin]

I made a plugin, mostly motivated by working around this: https://github.com/jcorbin/neovim-termhide ; basically, for me at least, :terminal is only currently usable in combination with setlocal bufhidden=hide ( ala https://github.com/jcorbin/neovim-termhide/blob/master/autoload/termhide.vim#L55 )