vim-patch:8.1.{27,32,36,69,70,71,91,92} #10433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erw7
changed the title
bfredl
reviewed
Jul 6, 2019
bfredl
reviewed
Jul 6, 2019
erw7
changed the title
This comment has been minimized.
This comment has been minimized.
justinmk
reviewed
Jul 27, 2019
| *termdebug-prompt* | ||
| When on MS-Windows, gdb will run in a buffer with 'buftype' set to "prompt". | ||
| This works slightly differently: | ||
| - The gdb window will be in Insert mode while typing commands. Go to Normal |
There was a problem hiding this comment.
why does it need to be different on Windows?
There was a problem hiding this comment.
Communicating with gdb requires a pty, but Windows can not get a pty. Therefore, Windows needs prompt buffer.
There was a problem hiding this comment.
I thought that winpty could be used for that. jobstart(...,{'pty':v:true}) works on Windows AFAIK.
There was a problem hiding this comment.
I thought that winpty could be used for that.
If winpty provides a named pipe connected to a hidden console to pass to gdb, there is possibility to work. However, the current winpty does not provide such a pipe. Therefore, I think that does not work with the current winpty.
justinmk
reviewed
Jul 27, 2019
justinmk
reviewed
Jul 27, 2019
erw7
changed the title
|
In this PR, vim-8.1.0036 is only partially applied. If we import vim-8.1.0035 in the future, we will also need to import the rest of vim-8.1.0036. |
|
Scheduled for 0.5. @erw7 please leave a comment if this sits around for too long. |
erw7
changed the title
|
Hey, Just wanted to point out that a very popular and useful Vim only plugin vimspector can't work in Neovim because of these patches not merged. A PR is waiting. |
|
@doronbehar |
|
On NixOS, the build failed with: |
Not related to this PR/patch, is it? |
This was referenced Sep 25, 2019
|
@erw7 |
3 tasks
@blueyed I'm afraid not, that vimspector PR is not ready yet but I've notified it's author about my attempt to try it along with this PR merged. I hope that never the less the maintainers will consider merging this sooner then in |
|
Just a friendly reminder |
|
Ping, this seems to be the main blocker for Neovim support in Vimspector |
|
@erw7 @blueyed |
|
@Billy4195 Thanks. I have updated this branch with your branch. |
… job Problem: Difficult to make a plugin that feeds a line to a job. Solution: Add the nitial code for the "prompt" buftype. vim/vim@f273245
Problem: BS in prompt buffer starts new line.
Solution: Do not allows BS over the prompt. Make term_sendkeys() handle
special keys. Add a test.
vim/vim@6b810d9
…r with mouse
Problem: Not restoring Insert mode if leaving a prompt buffer by using a
mouse click.
Solution: Set b_prompt_insert appropriately. Also correct cursor position
when moving cursor to last line.
vim/vim@891e1fd
Problem: Cannot handle pressing CTRL-C in a prompt buffer. Solution: Add prompt_setinterrupt(). vim/vim@0e5979a
…pt() Problem: Missing part of the changes for prompt_setinterrupt(). Solution: Add the missing changes. vim/vim@222cd20
…ature
Problem: Terminal debugger only works with the terminal feature.
Solution: Make it also work with a prompt buffer. Makes it possible to use
on MS-Windows. Various other improvements. (closes vim/vim#3012)
vim/vim@b3307b5
…running
Problem: MS-Windows: Cannot interrupt gdb when program is running.
Solution: Add debugbreak() and use it in the terminal debugger.
Respect 'modified' in a prompt buffer.
vim/vim@4551c0a
Problem: Prompt buffer test fails.
Solution: Set 'nomodified' before closing the window. (Ozaki Kiichi,
closes vim/vim#3051
vim/vim@71ef1ba
Import necessary part of vim-patch:8.1.1575. vim/vim@75a1a94
|
Merging this since it includes various useful changes (e.g. the
Thanks @erw7 and @Billy4195 |
justinmk
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vim-patch:8.1.0027: difficult to make a plugin that feeds a line to a job
Problem: Difficult to make a plugin that feeds a line to a job.
Solution: Add the nitial code for the "prompt" buftype.
vim/vim@f273245
vim-patch:8.1.0032: BS in prompt buffer starts new line
Problem: BS in prompt buffer starts new line.
Solution: Do not allows BS over the prompt. Make term_sendkeys() handle special keys. Add a test.
vim/vim@6b810d9
vim-patch:8.1.0035: not easy to switch between prompt buffer and other windowsProblem: Not easy to switch between prompt buffer and other windows.
Solution: Accept CTRL-W commands in Insert mode. Start and stop Insert mode as one would expect.
vim/vim@6d41c78
vim-patch:8.1.0036: not restoring Insert mode if leaving prompt buffer with mouse
Problem: Not restoring Insert mode if leaving a prompt buffer by using a mouse click.
Solution: Set b_prompt_insert appropriately. Also correct cursor position when moving cursor to last line.
vim/vim@891e1fd
vim-patch:8.1.0042: if omni completion opens a window Insert mode is stoppedProblem: If omni completion opens a window Insert mode is stopped. (Hirohito Higashi)
Solution: Only set stop_insert_mode in a prompt buffer window.
vim/vim@f98b845
vim-patch:8.1.0064: typing CTRL-W in a prompt buffer shows mode "-- --"Problem: Typing CTRL-W in a prompt buffer shows mode "-- --".
Solution: Set restart_edit to 'A' and check for it.
vim/vim@942b454
vim-patch:8.1.0069: cannot handle pressing CTRL-C in a prompt buffer
Problem: Cannot handle pressing CTRL-C in a prompt buffer.
Solution: Add prompt_setinterrupt().
vim/vim@0e5979a
vim-patch:8.1.0070: missing part of the changes for prompt_setinterrupt()
Problem: Missing part of the changes for prompt_setinterrupt().
Solution: Add the missing changes.
vim/vim@222cd20
vim-patch:8.1.0071: terminal debugger only works with the terminal feature
Problem: Terminal debugger only works with the terminal feature.
Solution: Make it also work with a prompt buffer. Makes it possible to use on MS-Windows. Various other improvements. (closes vim/vim#3012)
vim/vim@b3307b5
vim-patch:8.1.0091: MS-Windows: Cannot interrupt gdb when program is running
Problem: MS-Windows: Cannot interrupt gdb when program is running.
Solution: Add debugbreak() and use it in the terminal debugger. Respect 'modified' in a prompt buffer.
vim/vim@4551c0a
vim-patch:8.1.0092: prompt buffer test fails
Problem: Prompt buffer test fails.
Solution: Set 'nomodified' before closing the window. (Ozaki Kiichi, closes vim/vim#3051)
vim/vim@71ef1ba