Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pty_no_echo option #10557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add pty_no_echo option #10557

wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jul 20, 2019

Ref: #9107

Given the number of options there are already, channel_job_start should be passed a struct for those instead maybe?

Also this uses pty_no_echo mainly because tv_dict_get_number defaults to 0 for a non-existing entry - but it is also clearer.

However, also for jobstart() it might make sense to at least group termios settings?!

@bfredl
Copy link
Member

bfredl commented Jul 21, 2019

should be a sub-dict to jobstart() options. If we add this option, it is reasonable to expect more flags will be requested.

we should probably make all pty related state a struct to common_job_start() (including size and TERM), to make the signature more manageable.

@justinmk
Copy link
Member

However, also for jobstart() it might make sense to at least group termios settings?!

See also #6992, there were tentative plans to make all termios options user-settable via jobstart().

Sub-dict is unfortunate but I don't have a better idea (string flags?).

@zeertzjq zeertzjq added the job-control OS processes, spawn label Dec 19, 2021
@dundargoc dundargoc changed the title RFC/WIP: add pty_no_echo option add pty_no_echo option Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
job-control OS processes, spawn
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants