Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: re-enable "tab drag in tabline to the left moves tab left" #10588

Merged
merged 5 commits into from Jul 24, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jul 23, 2019

Bad timing since tsan is flaky currently (but during make install).
I just came across this when investigating the above and wanted to see if it is still necessary.

@blueyed blueyed added test ci automation for build, test, and release labels Jul 23, 2019
@blueyed
Copy link
Contributor Author

blueyed commented Jul 23, 2019

So this appears to not be necessary anymore it seems.

@justinmk
Copy link
Member

it's indeterministic. we can try it, but if it still is a problem, fixing it is a very low priority and it should just be ignored again.

@blueyed
Copy link
Contributor Author

blueyed commented Jul 24, 2019

Different flaky failure, will merge it then for now:

[----------] Running tests from test/functional/autocmd/termclose_spec.lua
[ RUN      ] TermClose event triggers when fast-exiting terminal job stops: 44.63 ms OK
[ RUN      ] TermClose event triggers when long-running terminal job gets stopped: -- Output to stderr:
Vim: Caught deadly signal 'SIGHUP'
Vim: Finished.
CMake Error at /Users/travis/build/neovim/neovim/cmake/RunTests.cmake:66 (message):
  functional tests failed with error: SIGPIPE

@blueyed blueyed merged commit f08d10a into neovim:master Jul 24, 2019
@blueyed blueyed deleted the test-enable branch July 24, 2019 00:12
@blueyed blueyed changed the title [WIP/TEST] tests: re-enable "tab drag in tabline to the left moves tab left" tests: re-enable "tab drag in tabline to the left moves tab left" Jul 24, 2019
@bfredl
Copy link
Member

bfredl commented Jul 24, 2019

This test was made more robust in #6930, but for some reason I only removed the flakiness guard for a similar tabline test but not for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci automation for build, test, and release test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants