Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Travis: move coverage job to first stage #10673

Merged
merged 1 commit into from Aug 2, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 2, 2019

This swaps it with "gcc-32bit".
It is better to have the "coverage" job run than "gcc-32bit" in case of
flaky build failures - especially on master, since otherwise no base
coverage is available for future PRs.

This swaps it with "gcc-32bit".
It is better to have the "coverage" job run than "gcc-32bit" in case of
flaky build failures - especially on master, since otherwise no base
coverage is available for future PRs.
@blueyed
Copy link
Contributor Author

blueyed commented Aug 2, 2019

@justinmk Sorry for mentioning the "c" word.. ;)

@blueyed blueyed merged commit 1aedb9e into neovim:master Aug 2, 2019
@blueyed blueyed deleted the ci-travis-move-coverage-job branch August 2, 2019 13:48
@justinmk
Copy link
Member

justinmk commented Aug 2, 2019

Maybe gcc-functionaltest-lua could also go in stage 2.

@blueyed
Copy link
Contributor Author

blueyed commented Aug 2, 2019

Why? For fewer jobs in the first stage in general?
Not sure, but it might have a negative effect on total build time, if there are only 4 parallel jobs (but IIRC we have 5?)

@blueyed
Copy link
Contributor Author

blueyed commented Aug 3, 2019

We only have 3 jobs in the 2nd stage currently, so this is good I think: #10682

timeyyy pushed a commit to timeyyy/neovim that referenced this pull request Aug 9, 2019
This swaps it with "gcc-32bit".
It is better to have the "coverage" job run than "gcc-32bit" in case of
flaky build failures - especially on master, since otherwise no base
coverage is available for future PRs.
timeyyy pushed a commit to timeyyy/neovim that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants