win/os_env_exists(): workaround libuv bug #10734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os_env_exists() fails on MSVC build:
os_env_exists:104: uv_os_getenv(EMPTY_VAR) failed: -4094 UNKNOWN
- Revert 396a394
- HACK: Windows: return TRUE if uv_os_getenv() returns UV_UNKNOWN, until
libuv bug is fixed: libuv/libuv#2413
ref neovim@396a394#r34642361
1 task
blueyed
added a commit
to blueyed/neovim
that referenced
this pull request
Sep 12, 2019
This reverts commit 278c5d4.
blueyed
added a commit
to blueyed/neovim
that referenced
this pull request
Sep 25, 2019
This reverts commit 278c5d4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os_env_exists() fails on MSVC build:
trueifuv_os_getenv()returns UV_UNKNOWN, until Windows: uv_os_getenv() with empty (but defined) variable libuv/libuv#2413 is resolvedref 396a394#r34642361