Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Screen:expect: support "{MATCH:…}" #11004

Merged
merged 2 commits into from
Nov 10, 2019
Merged

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Sep 12, 2019

Initially done for #10978 (to match varying number of cols/rows) - but likely not useful there anymore.

Since I've missed this before it might be good to have it.
Though I cannot remember a use case where this could be used directly already. Hints?

@blueyed blueyed added the test label Sep 12, 2019
@bfredl
Copy link
Member

bfredl commented Sep 12, 2019

I guess it could be used where IGNORE is currently used to be more specific, like the intro screen tests. But it might not be a high-priority issue.

@bfredl
Copy link
Member

bfredl commented Sep 12, 2019

Also, if we do this, we should merge IGNORE into it, as IGNORE can just be expressed as match-everything regex .*.

@blueyed
Copy link
Contributor Author

blueyed commented Sep 25, 2019

A good use case:

{8:paste: Error executing lua: vim.lua:197: Vim:E21: }|
(the line number of the error message / location).

@justinmk
Copy link
Member

justinmk commented Sep 25, 2019

@blueyed I think we're all in favor of this, but maybe IGNORE should be replaced with MATCH:.* everywhere. That simplifies the docs at least . And line 277 needs an update:

--              "{MATCH:x}|" lines are matched against Lua pattern x.

@justinmk justinmk merged commit ece3d19 into neovim:master Nov 10, 2019
@blueyed blueyed deleted the tests-match branch November 11, 2019 16:41
@blueyed
Copy link
Contributor Author

blueyed commented Nov 11, 2019

@justinmk
Thanks for picking this up / finishing it.

btw: there's a new Github repo setting to delete branches automatically - I think it's good to enable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants