encoding: UTF-32 Assertion Failure #12010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix neovim crash when editing specific files as UTF-32 encoded. Replaces values above INT_MAX with U+FFFD.
zubairabid
force-pushed
the
utf32-assertion-failure
branch
from
fbcde3a
to
880f4fb
Compare
|
@bfredl would it be possible for you to take a look at this? |
|
Code looks fine. Ideally we would have some kind of test for this. Perhaps there are some existing tests for |
|
could you add a test similar to the last one in test/functional/core/fileio_spec.lua please ? |
|
Hi sorry, I got a bit derailed by classwork. I'll look into adding tests in the next couple of days. |
muniter
added a commit
to muniter/neovim
that referenced
this pull request
Nov 18, 2021
muniter
added a commit
to muniter/neovim
that referenced
this pull request
Nov 18, 2021
muniter
added a commit
to muniter/neovim
that referenced
this pull request
Nov 24, 2021
gpanders
pushed a commit
that referenced
this pull request
Nov 24, 2021
|
Superseded by #16354. |
Shougo
pushed a commit
to Shougo/neovim
that referenced
this pull request
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #11877. Replaced characters over INT_MAX with U+FFFD, as proposed in the discussion.
Behaviour is now identical to that of
vim -u DEFAULTS.Test coverage:
Linter: