Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following GitHub convention by adding a CONTRIBUTING.md file. #123

Merged
merged 1 commit into from
Feb 26, 2014
Merged

Following GitHub convention by adding a CONTRIBUTING.md file. #123

merged 1 commit into from
Feb 26, 2014

Conversation

jbranchaud
Copy link
Contributor

Adding CONTRIBUTING.md with the content from the contributing page of the wiki. GitHub recognizes this file and links to it when people try to contribute to a repository. This will help ensure that people understand the contribution guidelines set out for this project before they contribute.

@flugsio
Copy link

flugsio commented Feb 24, 2014

Communicating should probably be a real link.

@jbranchaud
Copy link
Contributor Author

@flugsio Thanks for catching that!

@tarruda
Copy link
Member

tarruda commented Feb 25, 2014

@jbranchaud nice, could you also explain that people looking for something to do can click in the waffle.io badge to see tasks ready to be worked on? Also squash the changes into one commit

@ashleyh
Copy link
Contributor

ashleyh commented Feb 25, 2014

Any thoughts on keeping this in sync with the wiki? Could just delete the wiki page but that increases PR merging workload.

1. Following GitHub convention by adding a CONTRIBUTING.md file.

2. Linking to the wiki page for communicating.

3. Referencing the waffle.io page for Neovim.
@jbranchaud
Copy link
Contributor Author

@ashleyh Perhaps we just come up with some concise, standard contributing guidelines (that won't change much, if at all) and the wiki can be used for more extensive explanation and information that changes frequently.

@jbranchaud
Copy link
Contributor Author

@tarruda I am not particularly familiar with squashing. I just read up on it and it is fairly straight-forward, but I have concerns about doing it when some commits have already been submitted as part of the pull request. Any guidance here?

@taketwo
Copy link

taketwo commented Feb 25, 2014

@jbranchaud After you are done with squashing do a push with --force flag. Assuming that the remote for your fork is called jbranchaud in your local clone you will want to do:

git push jbranchaud adding-contributing-doc --force

The old commits in this pull request will magically disappear, only the new one will be visible.

@jbranchaud
Copy link
Contributor Author

@taketwo That really was magic, thanks!

@tarruda I updated with the waffle stuff and then squashed the commits, let me know if you need anything else before merging it.

@rjw57
Copy link
Contributor

rjw57 commented Feb 26, 2014

@jbranchaud thanks for this. I'll merge now. Could you update the wiki to point to CONTRIBUTING.md? That way we don't need to keep them in sync.

@rjw57 rjw57 closed this Feb 26, 2014
@rjw57 rjw57 reopened this Feb 26, 2014
rjw57 added a commit that referenced this pull request Feb 26, 2014
Following GitHub convention by adding a CONTRIBUTING.md file.
@rjw57 rjw57 merged commit eb48932 into neovim:master Feb 26, 2014
@rjw57
Copy link
Contributor

rjw57 commented Feb 26, 2014

roll eyes merge and then close @rjw57 :).

@jbranchaud jbranchaud deleted the adding-contributing-doc branch February 28, 2014 23:33
dwb pushed a commit to dwb/neovim that referenced this pull request Feb 21, 2017
Add maker for Haskell's hdevtools.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants