bytetrack: fix J with trailing whitespace #12957
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfredl
reviewed
Sep 21, 2020
src/nvim/buffer_updates.c
Outdated
| @@ -289,7 +289,12 @@ void buf_updates_send_splice( | |||
| int new_row, colnr_T new_col, bcount_t new_byte) | |||
| { | |||
| if (!buf_updates_active(buf) | |||
| || (old_byte == 0 && new_byte == 0)) { | |||
| || (old_row == 0 | |||
There was a problem hiding this comment.
this a bit weird, ideally we want to assert that old_byte == 0 iff old_row == 0 && old_col == 0 (and :s/old/new/g )
There was a problem hiding this comment.
though we can do this in the test layer, to avoid unpleasant crashes for now (can escalate later)
There was a problem hiding this comment.
Oh I see, removing from this PR then
vigoux
force-pushed
the
byte-join-trailing
branch
7 times, most recently
from
16600cf
to
03f6e8c
Compare
|
This PR does not solve the issue I am having, for which I lack a repro for now, I am digging into it though, as I really think this needs a fix. |
vigoux
force-pushed
the
byte-join-trailing
branch
from
03f6e8c
to
6cf93ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix this issue we had for a while, when joining lines with trailing whitespace on the line where you hit
J.