api: nvim_ex_call_luaref #13280
Open
api: nvim_ex_call_luaref #13280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think yes. |
bfredl
reviewed
Nov 13, 2020
| emsg_silent = true; | ||
| } | ||
|
|
||
| // Undefined behavior if you call vim.wait inside of here?... |
There was a problem hiding this comment.
why Undefined behavior? the same situation can already arise in vimscript with ex command modiifers
bfredl
reviewed
Nov 13, 2020
| char_u *save_eventignore; | ||
| if (!do_autocmds) { | ||
| save_eventignore = vim_strsave(p_ei); | ||
| set_string_option_direct( |
There was a problem hiding this comment.
is this really how ex commands do it?
bfredl
reviewed
Nov 13, 2020
| } | ||
|
|
||
| // Undefined behavior if you call vim.wait inside of here?... | ||
| Object rv = nlua_call_ref(cb, NULL, args, true, err); |
There was a problem hiding this comment.
note to self, add a flag to nlua_call_ref to preserve retval as a luaref (and also use it for nvim_buf_call.
bfredl
reviewed
Nov 13, 2020
| /// local wrapped = vim. | ||
| // | ||
| // nvim_ex_call_function({bufdo = {1, 3, 7, 8}}, my_lua_cb, ...) | ||
| Object nvim_ex_call_luaref(Dictionary opts, LuaRef cb, Array args, Error *err) |
There was a problem hiding this comment.
this can just be called nvim_ex_call or something without "lua" in the name.. The documentation will automatically indicate that it is "lua only" for now, and we can extend it later to rpc and/or vimscript.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bfredl what do you think about the general idea?