[RFC] Fixes to input/job modules #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarruda
referenced
this pull request
in tarruda/neovim
Oct 30, 2014
The `rbuffer_consumed` was being passed a consumed count from another buffer, causing integer overflow in `rbuffer_relocate`. Fixes neovim#1343
tarruda
changed the title
- Extract `process_interrupts` out of `convert_input` - Instead of waiting for os_breakcheck/os_inchar calls, call `convert_input` and `process_interrupts` directly from the read callback in input.c. - Remove the `settmode` calls from `job_wait`. Now that interrupts are processed in the event loop, there's no need to set the terminal to cooked which introduces other problems(ref 7.4.427)
tarruda
force-pushed
the
patch-427-workaround
branch
3 times, most recently
from
2e8e7a8
to
4d9cc0a
Compare
Input buffer must be bigger than read buffer to ensure it always has space for converted data.
The `vim_feedkeys` must be deferred because it can potentially free the buffer passed to `os_inchar`(which in turns calls `vim_feedkeys` indirectly). The new `vim_input` function can be used to emulate user input(Since it does not mess with the typeahead, it is safe to execute without deferring).
tarruda
force-pushed
the
patch-427-workaround
branch
from
4d9cc0a
to
9e41dd0
Compare
tarruda
added a commit
that referenced
this pull request
Oct 30, 2014
splinterofchaos
pushed a commit
to splinterofchaos/neovim
that referenced
this pull request
Oct 30, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process_interruptsout ofconvert_inputconvert_inputand
process_interruptsdirectly from the read callback in input.c.settmodecalls fromjob_wait. Now that interrupts areprocessed in the event loop, there's no need to set the terminal to cooked
which introduces other problems(ref 7.4.427)
This is also good because it will simplify handling ctrl+c in the middle of server->client msgpack-rpc calls