[RDY] Notification provider #13843
[RDY] Notification provider #13843
Conversation
|
I'm in favor of removing anything that pipes to Maybe we could roll (the idea) of my PR handling verbosity with nvim_err into this one? |
teto
force-pushed
the
notif_provider
branch
2 times, most recently
from
ebcaf16
to
0380e9d
Compare
|
@mjlbach I find this small PR quite useful already so I prefer to keep the scope minimal to speed up merging (then we can start leveraging it in LSP). I will comment on your other PR. I've swapped the log level and message so one doesn't need to specify a log level anymore. NB: freebsd build errors unrelated |
| function vim.notify(msg, log_level, _opts) | ||
|
|
||
| if log_level == vim.log.levels.ERROR then | ||
| vim.api.nvim_err_writeln(msg) |
There was a problem hiding this comment.
which reminds me, nvim_echo should take optional 'error' arg :)
|
Should we add Might nice for remote plugins. |
|
good idea, I've just added nvim_notify. |
Adds function to notify the user like this:
`:lua vim.notify("hello user")`
embeds log levels vim.log.levels.
you can then reassign vim.notify to for instance
```
function notify_external(msg, log_level, opts)
vim.fn.jobstart({"notify-send", msg })
end
```
|
Could use a test where we call notify and do screen test in Lua. Could use a test from api side where you override This also gives us that the code runs once 😁 After that, I'm good with merging. |
|
Oh, maybe we should add a name space or provider argument. So you could multiplex them if you wanted. |
teto
force-pushed
the
notif_provider
branch
2 times, most recently
from
3c31490
to
eb3abe4
Compare
|
I've added a test, was not sure how to test the default behavior. I am fine with adding a namespace (and I think nvim_echo should too, this would allow to filter messages per plugin). but not sure if it deserves its own parameter or can be passed into the dicts. |
parameters are mandatory
|
There was no comment on the namespace argument so I'll merge, We can change this before release concurrently with nvim_echo (or post release via the optional dict). |
| #define DEBUG_LOG_LEVEL 1 | ||
| #define INFO_LOG_LEVEL 2 | ||
| #define WARN_LOG_LEVEL 3 | ||
| #define ERROR_LOG_LEVEL 4 |
There was a problem hiding this comment.
This changes behavior, where CMAKE_EXTRA_FLAGS += -DMIN_LOG_LEVEL=1 now enables debug messages, whereas it was INFO only before..! (e.g. via
Line 185 in 4174244
Since it is released in 0.5 already it should probably stay like this, but it seems like documentation (and CI config) needs to be adjusted also (e.g.
neovim/.github/workflows/env.sh
Line 30 in 4174244
Address #5562 : notifications in the command line are a pain, especially wit LSP now.
I would like the possibility to use system notifications for instance (or floating windows to mimic system level notifications).
Adds a
vim.notifyfunction to send such notifications. By default it sends it as usual but you can override it with for instanceI've noticed a mismatch between
neovim/runtime/lua/vim/lsp/log.lua
Line 13 in 8950f4e
neovim/src/nvim/log.h
Line 20 in 8950f4e
Also could support a dict to be forward compatible with options (timeout, icon).
@mjlbach @tjdevries @bfredl