[RFC] Fix excessive grid_scrolls on ext_messages+small window #13909
Conversation
This commit fixes excessive redraws that would happen when ext_messages is used with a scrolloffset larger than the window. The reason we need to use `plines <= so * 2` is that the window needs to accomodate both the scroll offset (so * 2) and the line the cursor is on, so there isn't enough room even if plines is equal to (so * 2). Closes neovim#12810.
glacambre
changed the title
glacambre
changed the title
| @@ -892,7 +892,7 @@ void curs_columns( | |||
| extra += 2; | |||
| } | |||
|
|
|||
| if (extra == 3 || plines < so * 2) { | |||
| if (extra == 3 || plines <= so * 2) { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
I strongly believe that new behavior is more correct than the previous one and thus that the oldtest need to be updated, could somebody else confirm? |
| os.remove('Xtest') | ||
| end) | ||
|
|
||
| it('ext_messages doesnt trigger unnecessary grid_scrolls', function() |
There was a problem hiding this comment.
Is this really connected to ext_messages at all? don't we see the same change of behaviour without ext_messages but with three grid lines (so still two for the window) ?
There was a problem hiding this comment.
I had tried to reproduce it with the TUI and failed, but I just tried again and succeeded, so there's indeed nothing ext_messages-specific here.
In fact, Vim seems to have this bug too, so would you prefer that I fix it upstream and then port the patch to Neovim?
There was a problem hiding this comment.
It would make sense to report the issue upstream yes, but if the fix is the same you can just add the vim-patch tag to the commit message.
|
My Vim patch was included in #13908 , so this PR can be closed. Thanks a lot for the reviews! |
No description provided.