Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): fix nvim_buf_set_extmark #15932

Merged
merged 1 commit into from
Oct 7, 2021
Merged

fix(api): fix nvim_buf_set_extmark #15932

merged 1 commit into from
Oct 7, 2021

Conversation

erw7
Copy link
Contributor

@erw7 erw7 commented Oct 6, 2021

Fix the problem of calling clear_virttext on undefined variables.

May be fixes #15927.

@github-actions github-actions bot added the api libnvim, Nvim RPC API label Oct 6, 2021
@clason clason added marks marks, extmarks, decorations, virtual text, namespaces and removed api libnvim, Nvim RPC API labels Oct 6, 2021
@justinmk
Copy link
Member

justinmk commented Oct 6, 2021

Nice. It might be more robust/maintainable if we move the Decoration decor = DECORATION_INIT; declaration to the top of the function? It should always be safe to use goto error , this is more future-compatible.

src/nvim/api/buffer.c Outdated Show resolved Hide resolved
Fix the problem of calling clear_virttext on undefined variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marks marks, extmarks, decorations, virtual text, namespaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault (core dumped) in clear_virttext
5 participants