Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim-patch:8.2.3664,8.2.3743,8.2.3747,8.2.3748,8.2.3757 #16541

Merged
merged 8 commits into from
Dec 10, 2021

Conversation

jamessan
Copy link
Member

@jamessan jamessan commented Dec 6, 2021

vim-patch:8.2.3664: cannot adjust sign highlighting for 'cursorline'

Problem: Cannot adjust sign highlighting for 'cursorline'.
Solution: Add CursorLineSign and CursorLineFold highlight groups.
(Gregory Anders, closes vim/vim#9201)
vim/vim@e413ea0

vim-patch:8.2.3743: ":sign" can add a highlight group without a name

Problem: ":sign" can add a highlight group without a name.
Solution: Give an error if the group name is missing. (closes vim/vim#9280)
vim/vim@5e18ccc

vim-patch:8.2.3747: cannot remove highlight from an existing sign

Problem: Cannot remove highlight from an existing sign. (James McCoy)
Solution: Only reject empty argument for a new sign.
vim/vim@0bac5fc

vim-patch:8.2.3748: giving an error for an empty sign argument breaks a plugin

Problem: Giving an error for an empty sign argument breaks a plugin.
Solution: Do not give an error.
vim/vim@e5710a0

vim-patch:partial 6304be625ce4

Update runtime files.
vim/vim@6304be6

Remaining changes left out of 03d250e

vim-patch:8.2.3757: an overlong highlight group name is silently truncated

Problem: An overlong highlight group name is silently truncated.
Solution: Give an error if the name is too long. (closes vim/vim#9289)
vim/vim@f7f7aaf


Closes #16494

@github-actions github-actions bot added vim-patch See https://neovim.io/doc/user/dev_vimpatch.html column sign/number column labels Dec 6, 2021
@jamessan jamessan changed the title vim-patch:8.2.3664,8.2.3743,8.2.3747,8.2.3748,partial,6304be625ce4 vim-patch:8.2.3664,8.2.3743,8.2.3747,8.2.3748 Dec 6, 2021
Copy link
Member

@zeertzjq zeertzjq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC a change in cursor_spec.lua is needed every time a highlight group has been added. E.g. 3202478#diff-d85bbab3c3d4b8241f7b2330a679e65388cd7b62f7e00f064bc49e993735374f.

@jamessan
Copy link
Member Author

jamessan commented Dec 6, 2021

IIRC a change in cursor_spec.lua is needed every time a highlight group has been added. E.g. 3202478#diff-d85bbab3c3d4b8241f7b2330a679e65388cd7b62f7e00f064bc49e993735374f.

If that's the case, then the test should really fail when that doesn't happen...

Edit: Oh, it does :)

@zeertzjq

This comment has been minimized.

@zeertzjq

This comment has been minimized.

@jamessan
Copy link
Member Author

jamessan commented Dec 7, 2021

I'll update again once vim/vim#9289 is handled, so I can include those changes.

@zeertzjq
Copy link
Member

zeertzjq commented Dec 8, 2021

The test introduced in vim/vim@f7f7aaf seems to depend on some earlier patches.

@jamessan
Copy link
Member Author

jamessan commented Dec 9, 2021

The test introduced in vim/vim@f7f7aaf seems to depend on some earlier patches.

I'll just add the function with that one test for now. The rest can be fleshed out when the older patches are ported.

jamessan and others added 8 commits December 8, 2021 21:47
Problem:    Cannot adjust sign highlighting for 'cursorline'.
Solution:   Add CursorLineSign and CursorLineFold highlight groups.
            (Gregory Anders, closes vim/vim#9201)
vim/vim@e413ea0
Problem:    ":sign" can add a highlight group without a name.
Solution:   Give an error if the group name is missing. (closes vim/vim#9280)
vim/vim@5e18ccc
Problem:    Cannot remove highlight from an existing sign. (James McCoy)
Solution:   Only reject empty argument for a new sign.
vim/vim@0bac5fc
… a plugin

Problem:    Giving an error for an empty sign argument breaks a plugin.
Solution:   Do not give an error.
vim/vim@e5710a0
Update runtime files.
vim/vim@6304be6

Remaining changes left out of 03d250e
…cated

Problem:    An overlong highlight group name is silently truncated.
Solution:   Give an error if the name is too long. (closes vim/vim#9289)
vim/vim@f7f7aaf
@jamessan jamessan changed the title vim-patch:8.2.3664,8.2.3743,8.2.3747,8.2.3748 vim-patch:8.2.3664,8.2.3743,8.2.3747,8.2.3748,8.2.3757 Dec 9, 2021
src/nvim/syntax.c Show resolved Hide resolved
@jamessan jamessan merged commit ac2d140 into neovim:master Dec 10, 2021
@jamessan jamessan deleted the vim-8.2.3664 branch December 10, 2021 02:29
zeertzjq pushed a commit to zeertzjq/neovim that referenced this pull request Dec 10, 2021
vim-patch:8.2.3664,8.2.3743,8.2.3747,8.2.3748,8.2.3757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
column sign/number column vim-patch See https://neovim.io/doc/user/dev_vimpatch.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight groups not properly cleared ("Too many highlight and syntax groups")
4 participants