Only warn about offset encoding differences once per buffer

[levouh]

Not sure if this is the right way to go about doing this, but after the commit here every time I type in insert-mode with clangd (reports { "utf-8", "utf-16" }) and null-ls (reports "utf-16") attached attached to a buffer, I get this warning.

Perhaps there is something deeper going on where I should be forcing a client to use a particular encoding? If that is the case, feel free to close this.

Otherwise, it seems sufficient to only warn about this once per buffer; it can be assaulting to have it every time this function is called (especially if using something like nvim-notify).

[levouh]

Perhaps it would be better to check the type of each of the reported client.config.capabilities.offsetEncoding values and check if they overlap (e.g. "utf-8" in { "utf-8", "utf-16" }).

It is also possible that I have something wrong in my configuration with the passed capabilities when initializing each server, so checking that first.

Moving to a draft for now as this is not in a truly ready state at all; just a potentially wrong solution to a problem that might not even exist.

[mjlbach]

I'd rather fix the offset encoding issues (really, the buf_request api issue) in the 0.7 cycle than add workarounds for a plugin in core.

[ranjithshegde]

Perhaps there is something deeper going on where I should be forcing a client to use a particular encoding? If that is the case, feel free to close this.

Absolutely. I had the same problem with clangd (when attached with other lsps).
You could simply do

    local capabilities = vim.lsp.protocol.make_client_capabilities()
    capabilities.offsetEncoding = { "utf-16" }
    require('lspconfig').clangd.setup({capabilities = capabilities})

I go with utf-16 as it is the default for most...

[mjlbach]

Yes forcing clangd to run in utf-16 is the best solution (for now).

[levouh]

Makes sense. Is this a bad idea to belligerently set for everything? I imagine it requires coordination with what the server supports.

[mjlbach]

Is this a bad idea to belligerently set for everything?

Yes, also running as utf-8 avoids some costly utf handling conversions. Nothing you will notice, that is just the advantage (neovim is utf-8 native)

[kylo252]

FWIW, you could also use this flag --offset-encoding=utf-16 with clangd.

[chrisfair]

Has this changed any lately I found myself having to do this in Lunarvim and it actually works poorly with another plugin I am trying to use.