Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lua): restore priority of the preloader #17302

Merged
merged 1 commit into from Feb 6, 2022
Merged

Conversation

lewis6991
Copy link
Member

@lewis6991 lewis6991 commented Feb 5, 2022

Neovim currently places its own loader for searching runtime files at the front of package.loaders. This prevents any preloaders in package.preload from being used. This change fixes that by moving the default package preloader to run before Neovim's loader. For example, LuaJIT provides preloaders for the built-in modules ffi and bit, so this optimisation will improve the loading of those.

@github-actions github-actions bot added the lua stdlib label Feb 5, 2022
@lewis6991 lewis6991 requested a review from bfredl February 5, 2022 18:02
Neovim currently places its own loader for searching runtime files at
the front of `package.loaders`. This prevents any preloaders in
`package.preload` from being used. This change fixes that by moving the
default package preloader to run before Neovim's loader. For example,
LuaJIT provides preloaders for the built-in modules `ffi` and `bit`, so
this optimisation will improve the loading of those.
@bfredl bfredl merged commit c7df847 into neovim:master Feb 6, 2022
@lewis6991 lewis6991 deleted the pkg_ldr branch August 15, 2022 08:18
@dundargoc dundargoc removed the request for review from bfredl November 7, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lua stdlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants