[RFC] Getting exit status from job with job-control #1844

- regression by 04c0658

Update runtime files and translations. https://code.google.com/p/vim/source/detail?r=31f7581068a9c3119e3bd2cd74160eb8282c3c6e

Problem: Memory access error. (Dominique Pelle) Solution: Update tpos. (Christian Brabandt) https://code.google.com/p/vim/source/detail?r=v7-4-514

Problem: With a wrapping line the cursor may not end up in the right place. (Nazri Ramliy) Solution: Adjust n_extra for a Tab that wraps. (Christian Brabandt) https://code.google.com/p/vim/source/detail?r=v7-4-517

Configuration for clang-format and related utilities. Examples: clang-format -style=file <file> git clang-format -style=file <commit> git diff -U0 HEAD^ | clang-format-diff.py -i -p1 -style=file

@justinmk

- @justinmk: Clarify comments - Match verbiage used in other api/*.c files - Fix a few typos/missing words

Executing old tests leaves an empty file 'del' that doesn't get removed by `make clean`.

The test was hoping to not find a tags file, but didn't actively guard against it. In my case, I had a tags file present which was causing different output to be generated. To fix this, let's set the tags option to look for an unlikely filename.

The corresponding code was already removed in b4ca3ab

python_spec.lua depends on the python client installed.

`job_send` is non-blocking and can potentially fail due to the following `job_stop` call. Since we can't reliably verify that the "exit" event is only sent after the "stdout" event, mark the test as pending and fix after we can get a notification about `job_send` status.

It appears that commit 393c1c59a27591d705648919b2d7fb921cba37bc (unix: set non-block mode in uv_{pipe,tcp,udp}_open) has broken Neovim's drawing under OSX. Let's revert to 1.2.0 until we can figure out what is happening and get it fixed.

This makes it possible to highlight the lines starting with ~ at the end of buffers and other elements highlighted using NonText. As proposed by mhinz at https://groups.google.com/forum/#!topic/vim_dev/p3de1iU1GXI/discussion

Problem : Negative array index read @ 909. Diagnostic : False positive. Rationale : Suggested error path assigns a negative value to idx at line 836 (`idx = find_command(ca.cmdchar);`). That's impossible, as `ca.cmdchar` is set to Ctrl_BSL just two lines above, so we know that value will be in the table. Resolution : Assert idx >= 0.

Diagnostic : False positive. Rationale : Coverity thinks we are forgetting to add more char to hold NULL, but it's not taking into account that two chars from cntxformat will no be present in the result. In fact, we can even allocate one byte less than currently done. Resolution : Add explanatory comment and allocate one less byte. Marked as "Intentional" at coverity's database.

Problem : String not null terminated @ 1165. Diagnostic : False positive. Rationale : Code below terminates string (with NUL or '\n'). Resolution : Add explanatory comment, and assert termination. Mark as Intentional at coverity's database.

Problem : Argument cannot be negative @ 1165. Diagnostic : Real issue. Rationale : len can be assigned a negative value @ 1162; len is passed as an unsigned argument @ 1165. Resolution : Refactor variable's types: - Use ftello instead of ftell to avoid using long. - Assert ftello result is safely convertible to size_t. - Introduce variable read_size to avoid using i (int).

Problem : Unitialized scalar variable @ 3239. Diagnostic : Harmless issue. Rationale : It's true pos.coladd is not initialized when calling searchit(). But that's no problem, as coladd is only set in that function. Resolution : Initialize variable to 0.

Disable JIT to find cause for random `PANIC: unprotected error in call to Lua API` on Travis (OS X).

- Factor out main_msg() in favor of mch_msg() and manual indentation, as to provide a much closer representation to the actual output of '--help'. 'gcc -E' reveals that main_msg() only consists of 3 printf calls anyways. - Factor out for loop used for printing top part of usage text; just print the text normally. usage() text: - Don't print the version; that's what '--version' is for. - Be consistent about nomenclature, e.g. '<arg>' denotes required argument, '-h | --help' denotes '-h' and '--help' are equivalent, etc. - Change some instances of vim{,rc,info} to nvim

While we're here: - Remove references to the '+diff' feature, which has since been made non-optional. - Update a few Vim instances with Nvim.

Fixes neovim#1301.

The systemlist test currently calls the `echo` command which can potentially complete before being interrupted, causing random test failures. Use `yes | xargs` instead. A `yes` invocation that is not piped through `xargs` can produce a huge amount of lines in a very short time, leading memory starvation when the result is being converted into a list. `xargs` ensures only one line of output will be produced while allowing interrupt to be tested.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC] Getting exit status from job with job-control #1844

[RFC] Getting exit status from job with job-control #1844

Commits on Feb 8, 2015