feat(channels): introduce v:parent #18561
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
justinmk
commented
May 17, 2022
| @@ -120,7 +119,30 @@ function vim._os_proc_children(ppid) | |||
| return children | |||
| end | |||
|
|
|||
| -- TODO(ZyX-I): Create compatibility layer. | |||
| -- Initializes v:parent (from server.c). | |||
| function vim._server_init() | |||
There was a problem hiding this comment.
Experimenting with defining core logic in Lua instead of C.
Will need to think more about where this kind of code lives, as we accumulate more of it.
justinmk
commented
May 17, 2022
| 'nvim-child', | ||
| api['version'], | ||
| 'remote', -- TODO: do we want a "child" or "nvim" client type? | ||
| vim.empty_dict(), -- TODO: Need api.functions dict (not list): https://github.com/neovim/neovim/pull/12040 |
There was a problem hiding this comment.
#12040 will help bring some consistency with the structure of api_info() and nvim_set_client_info which currently have some questionable incompatibilities.
justinmk
commented
May 17, 2022
|
|
||
| it('creates v:parent channel from $NVIM', function() | ||
| local nrchans = #meths.list_chans() | ||
| exec_lua([[return vim.fn.jobstart({ vim.v.progpath }, vim.empty_dict())]]) |
There was a problem hiding this comment.
I thought we had a convenience in the bridge where an empty {} was acceptable for a Dict param. Is it intentional / desired that vim.empty_dict() is required here? @bfredl
:lua lua =vim.fn.jobstart({ vim.v.progpath }, {})
E5108: Error executing lua Vim:E475: Invalid argument: expected dictionary
stack traceback:
[C]: in function 'jobstart'
[string ":lua"]:1: in main chunk
justinmk
force-pushed
the
parent
branch
3 times, most recently
from
f3deee1
to
f0f83ea
Compare
Explicitly closing the parent channel was an attempt to avoid noise in the logs. But the channels should already be cleared by Nvim event_teardown() and server_teardown() happens too late. Need to find another way to avoid log noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #11009
$NVIMautomatically, expose it asv:parent$NVIM, v:parent #3118:!) ?