ci: remove mingw job #18580
Merged
ci: remove mingw job #18580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mingw CI job takes a long time to finish and the benefit it provides is relatively low. A more thorough rationale and discussion can be found in the provided link. Closes neovim#18551
justinmk
approved these changes
May 15, 2022
justinmk
reviewed
May 15, 2022
justinmk
reviewed
May 15, 2022
justinmk
reviewed
May 15, 2022
| @@ -76,57 +76,6 @@ if(UNIX) | |||
| CC=${DEPS_C_COMPILER} PREFIX=${DEPS_INSTALL_DIR} | |||
| ${DEPLOYMENT_TARGET}) | |||
|
|
|||
| elseif(MINGW AND CMAKE_CROSSCOMPILING) | |||
There was a problem hiding this comment.
This we can definitely get rid of. Not sure if we need crosscompiling stuff at all.
justinmk
approved these changes
May 15, 2022
justinmk
approved these changes
May 15, 2022
|
Does CI still use msys for running oldtests? Lines 121 to 125 in e501e4e |
|
Honestly, I wasn't sure so I just left is as I didn't want to break something acidentally. |
Shougo
pushed a commit
to Shougo/neovim
that referenced
this pull request
May 17, 2022
Unnecessary CI builds increase the change of spurious failures, which are costly
noise. Of course, we should fix all legitimate bugs, but we also cannot
micro-manage every platform, so there needs to be a clear motivation for the CI
builds that we maintain.
Reasons against maintaining a mingw CI job:
1. The windows mingw build is slow.
2. Failures:
- neovim#18494
- neovim#18495
3. The mingw artifact is 10x bigger than the windows MSVC artifact:
neovim#10560
4. Our releases publish the MSVC (not mingw) artifact for Windows users:
https://github.com/neovim/neovim/releases
5. Non-MSVCRT has limitations documented by libuv: http://docs.libuv.org/en/v1.x/process.html
> On Windows file descriptors greater than 2 are available to the child process only if the child processes uses the MSVCRT runtime.
Closes neovim#18551
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
May 17, 2022
This partially reverts commit f8af814. The mingw parts of cmake was removed to see if it was still used (ref: neovim#18580). It turns out it is, so this will fix that. Closes: neovim#18597
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
May 17, 2022
This partially reverts commit f8af814. The mingw parts of cmake was removed to see if it was still used (ref: neovim#18580). It turns out it is, so this will fix that. Closes: neovim#18597
dmitmel
pushed a commit
to dmitmel/neovim
that referenced
this pull request
May 18, 2022
Unnecessary CI builds increase the change of spurious failures, which are costly
noise. Of course, we should fix all legitimate bugs, but we also cannot
micro-manage every platform, so there needs to be a clear motivation for the CI
builds that we maintain.
Reasons against maintaining a mingw CI job:
1. The windows mingw build is slow.
2. Failures:
- neovim#18494
- neovim#18495
3. The mingw artifact is 10x bigger than the windows MSVC artifact:
neovim#10560
4. Our releases publish the MSVC (not mingw) artifact for Windows users:
https://github.com/neovim/neovim/releases
5. Non-MSVCRT has limitations documented by libuv: http://docs.libuv.org/en/v1.x/process.html
> On Windows file descriptors greater than 2 are available to the child process only if the child processes uses the MSVCRT runtime.
Closes neovim#18551
kraftwerk28
pushed a commit
to kraftwerk28/neovim
that referenced
this pull request
Jun 1, 2022
Unnecessary CI builds increase the change of spurious failures, which are costly
noise. Of course, we should fix all legitimate bugs, but we also cannot
micro-manage every platform, so there needs to be a clear motivation for the CI
builds that we maintain.
Reasons against maintaining a mingw CI job:
1. The windows mingw build is slow.
2. Failures:
- neovim#18494
- neovim#18495
3. The mingw artifact is 10x bigger than the windows MSVC artifact:
neovim#10560
4. Our releases publish the MSVC (not mingw) artifact for Windows users:
https://github.com/neovim/neovim/releases
5. Non-MSVCRT has limitations documented by libuv: http://docs.libuv.org/en/v1.x/process.html
> On Windows file descriptors greater than 2 are available to the child process only if the child processes uses the MSVCRT runtime.
Closes neovim#18551
kraftwerk28
pushed a commit
to kraftwerk28/neovim
that referenced
this pull request
Jun 1, 2022
This partially reverts commit f8af814. The mingw parts of cmake was removed to see if it was still used (ref: neovim#18580). It turns out it is, so this will fix that. Closes: neovim#18597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mingw CI job takes a long time to finish and the benefit it provides
is relatively low. A more thorough rationale and discussion can be found
in the provided link.
Closes #18551