fix(float): make screen*() functions respect floating windows
#19020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed commit that addresses |
bfredl
reviewed
Jun 19, 2022
bfredl
reviewed
Jun 19, 2022
bfredl
reviewed
Jun 19, 2022
justinmk
reviewed
Jun 19, 2022
justinmk
reviewed
Jun 19, 2022
bfredl
reviewed
Jun 20, 2022
|
Just to be sure, is there anything else I can/should do to get this merged? |
|
@echasnovski looks alright, squash? |
echasnovski
force-pushed
the
screenchar-float
branch
from
bf9a899
to
9f28edd
Compare
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #19013. I hope it fixes the problem of ignoring floating windows while not breaking other tests. Tested this fix on custom
get_screenshot()(basically callingscreenstring()andscreenattr()on all cells from1..vim.o.lines x 1.vim.o.columns) with several overlapping floating windows. Seems to work.Disclaimer: I don't know much about Neovim C codebase (and C in general). I mostly copied and modified
ui_comp_mouse_focus()which seems to properly handle floating windows for mouse functionality. This might be suboptimal, but works for cases I tested.