fix: emoji "Regional Indicator Symbols" handling #19259
Conversation
loops
changed the title
loops
changed the title
|
I notice above it says: "Still in progress? Convert to draft" Which I don't understand, and am not sure if there's something I should be doing to move things forward? |
See above the comment box:
|
Thanks. But I don't understand what a draft pull request is. How did it get marked "draft", how do you mark it as no-longer-in-draft? |
Click the "ready for review" button. "Draft" is generally used to indicate "this isn't ready for a final review or merge, just some WIP". Not sure how it ended up in draft; the details on the issue don't indicate that. |
|
CI is failing mostly because commit messages must conform to a strict standard, see: https://github.com/neovim/neovim/blob/master/CONTRIBUTING.md#commit-messages I think commit messages should be prefixed with |
The regional indicator symbol characters 0x1F1E6 to 0x1F1FF (as given in www.unicode.org/charts/PDF/U1F100.pdf) are by themselves double width characters. And as such, currently are allocated two virtual columns when displayed. However, in actuality these characters are almost always used in pairs that represent a country flag. Within a terminal window, the flag is displayed as a double width character. But we incorrectly allocate 4 virtual columns for the displayed flag, (two combining-characters multiplied by two virtual columns each). Unfortunately, there is no good way within the code to indicate that these characters should be handled differently when combined in sequence. On balance, editing is much easier if we properly handle the usual case where they appear as combined characters, and thus accept the minor visual glitch when they appear as lone characters. While not ideal, special case these unicode regional indicator emoji symbols as single width. Neovim issues #19258 #16447
Thanks very much for your help. That was a commit I didn't even create, it was created by the review process -- i just approved it. This is the second problem that one step created, making this a bit of a frustrating experience. Ah well, hope it's all good now. |
The regional indicator symbol characters 0x1F1E6 to 0x1F1FF (as
given in www.unicode.org/charts/PDF/U1F100.pdf) are by themselves
double width characters. And as such, currently are allocated
two virtual columns when displayed.
However, in actuality these characters are almost always used in
pairs that represent a country flag. Within a terminal window,
the flag is displayed as a double width character. But we
incorrectly allocate 4 virtual columns for the displayed flag,
(two combining-characters multiplied by two virtual columns each).
Unfortunately, there is no good way within the code to indicate
that these characters should be handled differently when combined
in sequence.
On balance, editing is much easier if we properly handle the usual
case where they appear as combined characters, and thus accept the
minor visual glitch when they appear as lone characters.
While not ideal, special case these unicode regional indicator
emoji symbols as single width.
Neovim issues #19258 #16447